Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

Closed vocabulary fields give no feedback when free text is typed and not selected

Abierto Apto para principiantes
  • ¿Algo no está bien?
#6,119 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 3 días

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
68/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
angular, typescript
Área
frontend

Línea de trabajo

Empieza con dynamic-onebox.component.ts, especialmente con DsDynamicOneboxComponent.onBlur(), y sigue cómo su evento blur llega a ds-dynamic-form-control-container y al estado del FormControl. Reproduce el caso descrito con un campo onebox obligatorio de vocabulario cerrado y texto que no coincide. Se considera terminado cuando, al salir del campo, se muestra una indicación visible de que el valor no es válido y el texto rechazado deja de mostrarse, sin cambiar el comportamiento de las sugerencias coincidentes.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

affects: 10.x affects: 8.x affects: 9.x bug component: controlled vocabulary component: submission

Describe the bug

On a submission form field that uses a closed vocabulary (<vocabulary closed="true">) with the onebox input type, typing text without picking a suggestion gives the user no feedback at all. The typed text is never written to the FormControl, which is correct for a closed vocabulary, but nothing marks the field as invalid or touched either, so no error message and no invalid styling appears. If the field is also required, the user only finds out the value was rejected when they try to deposit.

Two things in DsDynamicOneboxComponent.onBlur() contribute:

  • when the typeahead suggestion list is open, the method calls event.preventDefault() and event.stopImmediatePropagation() and returns without this.blur.emit(event). The error message under the field is drawn by ds-dynamic-form-control-container, which only clears its focus state when a blur event reaches it, so the message stays hidden.
  • nothing ever calls markAsTouched() or sets an error on the control for the closed vocabulary case, so even after the field is left there is no invalid state to render.

I ran into this on DSpace-CRIS 2025.02, but onBlur in dynamic-onebox.component.ts is identical on main and dspace-9_x, and markAsTouched does not appear in that file on either branch, so it should apply there too. Browser was Chrome.

To Reproduce

  1. Configure a submission form field with input-type onebox, a <required> message, and <vocabulary closed="true">
  2. Start a submission and type some text into that field that does not match any vocabulary entry
  3. Wait for the suggestion list to appear, then click somewhere else on the form while it is still open
  4. The field shows no error message and no invalid styling. The typed text also stays in the box even though nothing was stored.

Expected behavior

Leaving a closed vocabulary field with text that was never matched to an entry should mark the field invalid and show the required error message, the same way any other required field does when it is left empty. The box should not keep showing text that was not stored.

Related work

Related to #4501 and #4502, but not the same path. Those cover the hierarchical vocabulary tree modal. This one is the typeahead suggestion list on a flat closed vocabulary, and #4502 does not add any control state handling.

We have a fix running locally against 2025.02 that flags the control and emits the blur only when a closed vocabulary violation was actually detected. Happy to open a PR against main if that direction is wanted.

Lenguaje dominante
TypeScript
Estrellas
180
Forks
577
Merge medio
2 d 12 h
PR fusionados (30 d)
111

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de DSpace/dspace-angular

Todos los issues de DSpace/dspace-angular

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.