Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

Approval-gated action interrupted before its result is saved can never be retried

Abierto
  • ¿Algo no está bien?
#134 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 2 días

@DerekChia ya está trabajando en esto.

Desde el 10/10/2026.

  • #135 de @DerekChia — abierto
  • #141 de @charan-rathore — cerrado sin fusionar

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
68/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
node.js, sql, typescript
Área
backend, database, frontend

Línea de trabajo

Start with the action receipt and the claimAction/finishAction flow around the mcp_actions table and the POST /api/conversations/thread/connection-actions endpoint. Also trace the approval action card’s polling and retry controls, using the 60-second ConnectionService timeout as the stale-run threshold. Done means an interrupted result-less run can be reclaimed only by its original approval, fresh claims still receive 409, saved results remain protected, and the UI exposes a successful retry.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Problem

If the server stops between claiming an approval-gated MCP action (claimAction) and saving its result (finishAction), that (threadId, toolCallId) is bricked: every retry returns 409 This action is already running. forever, because mcp_actions rows have no expiry and there is no code path that clears a result-less running row.

Worse, the owner has no way to retry from the UI: the action card polls the receipt every 2s, sees status: running, shows "Running / This action is still running on the server.", and hides the Approve buttons while running is true. The card sits on "Running" forever with no affordance.

Reproduction

  1. Start OpenDots (local npm run dev, Node v22.23.1) with a Dot that has an MCP connection with a gated (non-read-only) tool.
  2. Have the Dot call the gated tool so the owner gets an approval card.
  3. Approve it, and kill the server process after the claim INSERT but before the result UPDATE lands (equivalently: INSERT INTO mcp_actions(threadId,toolCallId,connectionId,tool,status,result,createdAt,approvalId) VALUES('thread','tc1','c','tool','running',NULL,<now>,'<approvalId>');).
  4. Restart the server and open the conversation.
  5. The card shows "Running" forever; approving/refreshing never completes. POST /api/conversations/thread/connection-actions with the same approval returns 409 {"error":"This action is already running."} on every attempt, until the approval itself expires an hour later.

Expected: after the in-flight run is demonstrably gone, the receipt should surface the interruption and the same approval should be able to run the stored request again (the request is already bound to its exact connection/tool/arguments, and only that approval may reclaim it).

Actual: misleading "already running" 409 with no self-healing and no owner retry path.

Notes

  • MCP tool calls are bounded to 60s (ConnectionService timeout), so a result-less claim older than a few minutes cannot belong to a live run.
  • The fix must preserve the double-claim guard: a fresh running row must still 409 (double click / retried request must not execute twice), a saved result must still be returned only to its own approval, and a different approval must never steal the claim.
Lenguaje dominante
TypeScript
Estrellas
4.8k
Forks
690
Merge medio
1 d 15 h
PR fusionados (30 d)
43

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de CopilotKit/OpenDots

Todos los issues de CopilotKit/OpenDots

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.