Consider moving cryptopolicy related rules from fips group to crypto group

Abierto
  • ¿Algo no está bien?
#13,852 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 2 días

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
35/100
Tipo de issue
Refactorización
Claridad
Bastante claro
Estado de actividad
Estancado
Área
security

Línea de trabajo

Revisa PR 13840, los archivos group.yaml de fips y crypto, y las definiciones y remediations de fips_crypto_subpolicy, fips_custom_stig_sub_policy y posiblemente fips_crypto_policy_symlinks. Comprueba la aplicabilidad de los grupos y el orden de las reglas, especialmente la ruta de remediation fips:stig; se considera terminado cuando las reglas tienen la ubicación de grupo, la aplicabilidad y el orden de remediation funcional previstos.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

triaged

This issue is a follow-up to https://github.com/ComplianceAsCode/content/pull/13840
Basically, currently we have three rules which are located in the fips group and at the same time they are related to specific modifications of cryptopolicies.

  • fips_crypto_subpolicy
  • fips_custom_stig_sub_policy
  • and possibly also fips_crypto_policy_symlinks

Before the PR mentioned above was merged, the whole fips group had a platform in group.yaml which made it inapplicable in containers, bootc systems etc.
And this mostly makes sense because FIPS mode is achieved differently in containers and immutable systems.
The PR was rather a quick fix.
I think that ideally rules mentioned above should be moved to the crypto group which has no applicability restrictions.
And at the same time, the applicability of rules in the fips group could return back to the group.yml.
The thing which remains to be solved is to later ensure proper rule ordering in the crypto group. Especially the rule fips_custom_stig_sub_policy caused problems when it was placed after the general configure_crypto_policy rule. The problem was that when remediating (imagebuilder), the remediation of configure_crypto_policy could fail in case the fips:stig is configured, because it tries to configure policy which does not exist yet.
Of course, this would not happen if fips:stig would be shipped directly in the distro.
Ideas and comments welcomed.

Lenguaje dominante
Shell
Estrellas
2.8k
Forks
847
Merge medio
3 d 10 h
PR fusionados (30 d)
85

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de ComplianceAsCode/content

Todos los issues de ComplianceAsCode/content

Issues similares

Más issues de Shell/Bash

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.