Stores move to the world named "world" after a restart

Abierto
  • ¿Algo no está bien?
#63 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
68/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
java
Área
backend

Línea de trabajo

Start by reading CuboidSerializer, WorldSerializer, and the save/load path through Warehouse, then inspect the existing serialization tests. Reproduce the round trip with a world named custom_world and check how a missing world is handled. Done means the world survives save and load, missing worlds are logged without being saved as blank, and a test covers the round trip.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug

Problem

A store's world isn't restored when stores load. After a restart, every store with a location is placed in the world named world, whatever world it was created in.

data.shops saves the right world (world="custom_world"). CuboidSerializer passes the world node to WorldSerializer, which then reads node.node("location").getString("world"). That child doesn't exist, so the lookup falls back to its default, the literal string "world".

The effects depend on the server:

  • Stores in the Nether, the End or custom worlds move to the overworld at the same coordinates.
  • If the server has no world named world, the location's world is null, the store stops working, and the next save drops the world from the file.

Steps to reproduce

  1. Create a store in any world not named world.
  2. Restart the server.
  3. The store is now in world, and it's no longer reachable where it was built.

Reproduced with a save and load through Warehouse: a store in custom_world loaded with the world world.

Done when

  • A store keeps its world across a save and load.
  • A store whose world is missing is reported in the log and isn't overwritten with a blank world on save.
  • A test covers the round trip with a world not named world.
Lenguaje dominante
Java
Estrellas
1
Forks
0
Merge medio
2 h 35 min
PR fusionados (30 d)
14

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de BrendonButler/Shops

Todos los issues de BrendonButler/Shops

Issues similares

Más issues de Java

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.