Chat: bigger text option, and don't keep old matches' chat around

Abierto
  • ¿Algo no está bien?
#68 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 2 días

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
35/100
Tipo de issue
Nueva funcionalidad
Claridad
Necesita aclaración
Estado de actividad
Activo
Stack tecnológico
lua
Área
frontend

Línea de trabajo

Start with lib/debugplus/console.lua, compatibility/debugplus.lua, and api/chat.lua to trace chat rendering, font use, and lobby cleanup. The issue leaves the old-message behavior and defaults undecided, so first resolve the listed UX questions; then add the agreed text-size and history options and verify they apply to the open console and fading messages.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

What we want

  1. Bigger chat text. A setting for the chat text size.
  2. Old messages shouldn't hang around. Some option so chat from earlier matches doesn't stay on screen and in the log forever, for example clearing it when a new match is found, or hiding it. The right UX still needs deciding (see below).

Today

  • Chat is the console in lib/debugplus/console.lua (or DebugPlus's own console when that mod is loaded, compatibility/debugplus.lua).
  • Text is drawn with LÖVE's current font (love.graphics.getFont()), so its size is fixed: there is no setting for it.
  • The log keeps the last 500 messages (console.lua, #messages > 500) and is never cleared. Leaving a lobby (MPAPI.chat.cleanup in api/chat.lua) unhooks sending but keeps every message, so the last match's chat is still there in the next one.
  • With the console closed, new messages show for 5 seconds and fade over 1 second (showTime, fadeTime).

Text size

  • A size option in the mod's settings, for example Small / Medium / Large (or a slider), applied to both the open console and the fading messages.
  • Line wrapping and scrolling already measure with the font (font:getWrap, font:getHeight), so they should follow a bigger font, but the input line and window size need checking.
  • When DebugPlus is loaded its own console draws the text; we may only be able to size ours.

Old chat: options to decide between

Option Upside Downside
Clear the log when a new match is found Each match starts clean; simplest to explain Can't scroll back to what someone said last game (for a report, say)
Divider instead of clearing ("--- New match vs X ---") Keeps history, makes it clear what is old Old messages still fill the log
Hide old matches' messages, keep them in memory (show with a toggle or command, e.g. /history) Clean by default, nothing lost More to build and explain
Clear when leaving the lobby Matches the lobby lifecycle Same downside as clearing
A /clear command Player decides Doesn't help anyone who doesn't know about it

Open questions:

  • Default on or off? Which option is the default?
  • Should the fading on-screen messages (console closed) ever show a message from a previous match?
  • Reports: if a player wants to report chat from a finished match, does the server's copy cover that, so clearing the client log is safe?
  • Should the same setting cover system notices (yellow) or only player messages?
Lenguaje dominante
Lua
Estrellas
10
Forks
8
Merge medio
1 d 18 h
PR fusionados (30 d)
20

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de Balatro-Multiplayer/BalatroMultiplayerAPI

Todos los issues de Balatro-Multiplayer/BalatroMultiplayerAPI

Issues similares

Más issues de Lua

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.