Reading non-numeric tags is NaN
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 35/100
Research direction
Start in tagreader/web_handlers.py at line 489 and inspect how the Value column is processed after tags are read. Review the existing issue options—removing coercion or checking which tags are numeric—and confirm the intended behavior for non-numeric tags before making the change. Done means non-numeric tag values are preserved rather than unexpectedly coerced.
Written by the indexing model from the issue text.
Description
When reading tags that are not of numeric type, the tag is converted to a NaN value. This is due to line 489 of webhandlers.py and can be resolved by just removing the line. The line attempts to convert the tag to a numeric value, but it really should first check that the tag is numeric in the first place or allow the user to specify which tags are numeric.
# Ensure non-numericals like "1.#QNAN" are returned as NaN
df["Value"] = pd.to_numeric(df.Value, errors="coerce")
https://github.com/equinor/tagreader-python/blob/master/tagreader/web_handlers.py
- Dominant language
- Python
- Stars
- 55
- Forks
- 21
- Avg merge
- 11d 9h
- Merged PRs (30d)
- 2
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from equinor/tagreader-python
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
equinor/tagreader-python#474 · 1 comment ·
-
Difficulty 2/5 Under an hour Newbie friendliness 55/100
equinor/tagreader-python#473 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
equinor/tagreader-python#469 · 1 comment ·
-
Update documentation Open
Difficulty 3/5 1-2 days Newbie friendliness 35/100
equinor/tagreader-python#447 · 1 comment ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
equinor/tagreader-python#393 ·
All issues in equinor/tagreader-python
Similar issues
-
essnmx good first issue
Difficulty 1/5 Under an hour Newbie friendliness 95/100
-
[Feature] 奇物选择添加优先级 Open
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
syfoud/Simulated_Scepter#174 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Giskard-AI/giskard-oss#2840 · 1 comment ·
-
A claim comment carrying the issue number is silently declined while the workflow reports success Openarea: repo bug perceived difficulty: 2
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
yeti-platform/yeti#1380 ·