Special characters in tags

Open
#469 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
api

Research direction

Start by reproducing the failing Tagreader request with tags such as "47#13-SULPH" and "50#12-5%REC", then compare the generated XML payload URL with the browser result. Done means tags containing # and % are encoded correctly and Tagreader returns the expected measurement values.

Written by the indexing model from the issue text.

Description

There are some problems when the tags contains special characters, e.g., # and %.
Especially for some manual sampling points, the system number is folled by # then the sample point number, and what was measured at the sample point, e.g. "47#13-SULPH". This I was able to solve by replacing "#" with "%23". This is maybe a fix you could implement in the base code?

But the real issue appear to be when the tag contains "%". For some measurements, a percentage recovery is stated, e.g. "50#12-5%REC". Here I can replace the #, but if I replace "%" with "%25", Tagreader does not return any values. If I paste the XML payload URL into by browser, I can get the output which Tagreader should have gotten.

Dominant language
Python
Stars
55
Forks
21
Avg merge
2d 5h
Merged PRs (30d)
4

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from equinor/tagreader-python

All issues in equinor/tagreader-python

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.