Support For define.amd

Open
#60 11 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
38/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript
Domain
tooling

Research direction

Start in Loader.js and inspect how the loader currently exposes define.petals and opts out of the define.amd check. Review the issue discussion before changing compatibility behavior, then verify that Rollup recognizes the loader without breaking its existing AMD behavior. Done means the intended define.amd support is implemented and its compatibility trade-off is covered by the project’s available checks.

Written by the indexing model from the issue text.

Description

Trying to use rollup for a refactor of Backburner with @krisselden and others. I noticed that rollup has AMD check looks for define && define.amd. Loader.js explicitly opts out of this with define.petals, wondering if people would be opposed to just setting define.amd to true. It's not spec compliant, however loader.js is already not spec compliant in this regard.

Dominant language
JavaScript
Stars
79
Forks
69
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ember-cli/loader.js

All issues in ember-cli/loader.js

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.