Should throw error on VertxGen declared inside VertxGen/DataObject
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
Research direction
No files or tests are named. Start by locating the codegen processing for nested @VertxGen and @DataObject declarations, then reproduce the nested enum example from the issue. Done means the processor consistently reports an error or warning for declarations that cannot be processed, with the chosen behavior confirmed for both annotation types.
Written by the indexing model from the issue text.
Description
Currently, I've noticed a few generation errors regarding how classes and interfaces are annotated.
For example, if a @VertxGen interface has a enum declared inside, this will be valid java code and will compile and no warning is given by codegen. However, you will not be able to process such element.
@VertxGen
interface A {
@VertxGen
enum E { }
}
In the example above E will never be processed and no warning or error is raised. I think we should raise an error in this situation.
The same applies for @DataObject. During the processing we should guarantee that this isn't allowed. This pattern is a problem to es4x but may not be for other generators, so we may agree in raising a warning instead.
- Dominant language
- Java
- Stars
- 111
- Forks
- 88
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from eclipse-vertx/vertx-codegen
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 15/100
eclipse-vertx/vertx-codegen#361 ·
-
help wanted
Difficulty 4/5 3-5 days Newbie friendliness 35/100
eclipse-vertx/vertx-codegen#340 · 11 comments · 2 reactions ·
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 25/100
eclipse-vertx/vertx-codegen#335 ·
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 25/100
eclipse-vertx/vertx-codegen#320 · 4 comments ·
-
JPMS json mapperOpenbug help wanted
Difficulty 4/5 3-5 days Newbie friendliness 25/100
eclipse-vertx/vertx-codegen#315 ·
All issues in eclipse-vertx/vertx-codegen
Similar issues
-
[destination-snowflake] Custom domains rejected unlike source connectionsPossibly taken @kuza55 claimed this today. Openautoteam community connectors/destination/snowflake team/use
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
area-dashboard
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
component/operate kind/feature-request
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
Forge coverage prompts carry text the agent cannot act onPossibly taken @graalvmbot claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
oracle/graalvm-reachability-metadata#10572 ·
Maintainers usually reply within 1 day
-
[CI] Core CI doesn't run for changes to amoro-format-lance (and amoro-web)Possibly taken @MarkAlex1234 claimed this today. Open
Difficulty 1/5 Under an hour Newbie friendliness 88/100
Maintainers usually reply within 2 days