[CI] Core CI doesn't run for changes to amoro-format-lance (and amoro-web)
Maintainers usually reply within 2 days
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 88/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- github-actions, yaml
- Domain
- ci-cd
Research direction
Read core-hadoop2-ci.yml and core-hadoop3-ci.yml, focusing on their pull_request.paths lists. Add the amoro-format-lance/** path to both lists, then verify that changes under that module trigger the core CI workflows.
Written by the indexing model from the issue text.
Description
What happens
core-hadoop2-ci.yml and core-hadoop3-ci.yml build and test the whole reactor (./mvnw clean install ...), but on pull requests they only trigger on an explicit module list: amoro-ams, amoro-common, amoro-metrics, amoro-optimizer, amoro-format-{iceberg,paimon,hudi} and three amoro-format-mixed submodules. amoro-format-lance was added to the root pom.xml modules later and isn't in either list, and no other workflow mentions it.
amoro-ams/pom.xml depends on amoro-format-lance (test scope, plus compile scope in two profiles). So a PR that only changes amoro-format-lance/** runs no CI at all, neither lance's own tests nor the AMS tests that use it, and breakage only shows up on the next PR that touches a listed module.
amoro-web is in the same position: amoro-ams depends on the amoro-web artifact, but no workflow watches amoro-web/**. That may be intentional, since frontend-only changes would otherwise run the full core matrix, so I'm only flagging it.
Proposed fix
Add "amoro-format-lance/**" to the pull_request.paths of core-hadoop2-ci.yml and core-hadoop3-ci.yml. I have a two-line PR ready and will link it here.
(Found by comparing each workflow's paths: with the Maven module graph using npx github:Continuous-Actions/dynamic-monorepo audit. Disclosure: that's a GitHub Action I maintain. The fix itself is just the path entry.)
- Dominant language
- Java
- Stars
- 1.2k
- Forks
- 398
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 19
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from apache/amoro
-
fix: low-contrast secondary text color in global theme tokenMay be free again A pull request for this issue was closed without being merged. Openstale
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
apache/amoro#4157 · 1 comment ·
Maintainers usually reply within 2 days
-
fix: mock api server enabled in production build masks real error/loading uxMay be free again A pull request for this issue was closed without being merged. Openstale
Difficulty 1/5 Under an hour Newbie friendliness 78/100
apache/amoro#4155 · 1 comment ·
Maintainers usually reply within 2 days
-
[Bug]: Connection validation rejects bracketed IPv6 endpointsPossibly taken @hutiefang76 claimed this 2 days ago. Opentype:bug
Difficulty 2/5 1-3 hours Newbie friendliness 35/100
Maintainers usually reply within 2 days
-
[Bug]: Table pagination parameters can overflow or return server errorsPossibly taken @hutiefang76 claimed this 2 days ago. Opentype:bug
Difficulty 4/5 3-5 days Newbie friendliness 25/100
Maintainers usually reply within 2 days
-
[Bug]: Rapid table and database searches are not debouncedPossibly taken @hutiefang76 claimed this 2 days ago. Opentype:bug
Difficulty 3/5 1-2 days Newbie friendliness 25/100
Maintainers usually reply within 2 days
Similar issues
-
enhancement
Difficulty 1/5 Under an hour Newbie friendliness 88/100
helidon-io/helidon#12721 ·
Maintainers usually reply within 1 day
-
status: team-only type: dependency-upgrade
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
spring-projects/spring-boot#51966 ·
Maintainers usually reply within 1 day
-
Missing repro Platform: Android
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
software-mansion/react-native-reanimated#10816 · 2 comments ·
Maintainers usually reply within 1 day
-
area/docs backport/26.6 backport/26.8 kind/bug status/triage
Difficulty 1/5 Under an hour Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
[destination-snowflake] Custom domains rejected unlike source connectionsPossibly taken @kuza55 claimed this today. Openautoteam community connectors/destination/snowflake team/use
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day