15.16.0: list Print / Export "Current page" throws on every flat manage list - visibleRows is emitted only for hierarchy lists (#8434)

Open Beginner friendly
#8,548 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
75/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
javascript
Domain
frontend

Research direction

Start with list-page.js.template, especially the hierarchy conditional that defines visibleRows and the exportScopeRows(scope) code near the lines cited in the issue. Check how flat lists expose paginatedItems, then run the Print and Export “Current page” actions on both flat and hierarchy lists. Done means both actions use the current page on flat lists and retain the expanded tree behavior on hierarchy lists.

Written by the indexing model from the issue text.

Description

15.16.0: list Print / Export "Current page" throws on every flat (non-hierarchy) manage list (#8434)

Observed (dirigiblelabs/dirigible:15.16.0, any generated manage list without hierarchy:; reproduced on base-sales-invoices SalesInvoice): More actions -> Print -> Current page does nothing, and the console shows Alpine Expression Error: Cannot read properties of undefined (reading 'map'). Export -> Current page fails the same way. All records works for both.

Cause. list-page.js.template (v15.16.0) defines get visibleRows() only inside #if($hierarchyProperty) (from line 262; the getter is at line 329). exportScopeRows(scope) (line 943, added by PR #8455 for #8434) is emitted unconditionally and reads this.visibleRows.map(r => r.row) for 'page'. On a flat list visibleRows is undefined.

Expected. "Current page" prints / exports the current page, this.paginatedItems on a flat list, as the #8434 comment says ("the current page, or the expanded tree in tree mode").

Suggested fix. Emit visibleRows (or a flat fallback) outside the hierarchy block, or have exportScopeRows use this.paginatedItems when the hierarchy block is absent.

Impact. Every BusinessIntents module list: the "Current page" choice of both new menus is dead. Found by the BusinessIntents train 1.39.0 S suite (base-sales-invoices B65).

🤖 Generated with Claude Code

Dominant language
Java
Stars
278
Forks
97
Avg merge
15h 33m
Merged PRs (30d)
301

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from eclipse-dirigible/dirigible

All issues in eclipse-dirigible/dirigible

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.