The external registry folder watcher logs an ERROR with a NoSuchFileException stack trace for every temp file an editor's atomic save writes into the folder
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 82/100
Research direction
Read components/core/core-registry and inspect RecursiveFolderWatcher.syncFile, especially the exception handling around file copying. Reproduce with an atomic-save edit to a file in the external registry folder and observe the logs. Done when a temp file removed before copying no longer produces an ERROR stack trace, while the real edited file is still synced.
Written by the indexing model from the issue text.
Description
- Image:
dirigiblelabs/dirigible:15.1.0-java(sha256:dac354be94f21f222e88b81fd7fc6e68d9616ee7b4e12bcb1e9eef0465bd213f) - Reference:
dirigiblelabs/dirigible:15.1.0(sha256:449b8c948738a2bd7a4294a7bec1000a08bc1da1cd20f312f0e54383a7af325d)
Same behaviour on both images.
Steps
mkdir -p /tmp/ext && cp -r <sample-intent-money> /tmp/ext/
docker run -d -p 8080:8080 -v /tmp/ext:/ext -e DIRIGIBLE_REGISTRY_EXTERNAL_FOLDER=/ext dirigiblelabs/dirigible:15.1.0-java
# once ready, edit a file the way most editors save (temp file + rename):
sed -i 's/.multiply(line.VatRate)/.multiply(line.VatRate).multiply(java.math.BigDecimal.TEN)/' /tmp/ext/sample-intent-money/custom/LineVatAction.java
docker logs <container>
Observed
The edit is picked up: it is recompiled and the new value is served in about 12 s. But every such save logs two ERRORs with full stack traces for the editor's temp file:
[ERROR] o.e.d.c.r.w.RecursiveFolderWatcher - Failed to sync: /ext/sample-intent-money/custom/sedeL8Fzd
java.nio.file.NoSuchFileException: /ext/sample-intent-money/custom/sedeL8Fzd
at org.eclipse.dirigible.components.registry.watcher.RecursiveFolderWatcher.syncFile(RecursiveFolderWatcher.java:204)
(twice), then INFO Synced: .../LineVatAction.java. The default image logs the same pair.
Expected
A create/modify event for a file that is gone by the time it is copied is a benign race (sed -i, vim, most IDEs, git checkout). It should be skipped, or logged at DEBUG, not ERROR. The external registry folder is the deployment path the README names for applications (section "Java edition"), so these ERRORs reach log alerting on every edit.
Where
components/core/core-registry RecursiveFolderWatcher.syncFile: catch NoSuchFileException separately (or check Files.exists) before the generic IOException ERROR.
- Dominant language
- Java
- Stars
- 278
- Forks
- 97
- Avg merge
- 15h 33m
- Merged PRs (30d)
- 301
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from eclipse-dirigible/dirigible
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
eclipse-dirigible/dirigible#8636 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
eclipse-dirigible/dirigible#8548 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
eclipse-dirigible/dirigible#8354 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
eclipse-dirigible/dirigible#8240 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
eclipse-dirigible/dirigible#8238 ·
Maintainers usually reply within 1 day
All issues in eclipse-dirigible/dirigible
Similar issues
-
triage
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
xerial/sqlite-jdbc#1515 ·
Maintainers usually reply within 1 day
-
Area/Configuration Type/Improvement
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
ballerina-platform/static-code-analysis-tool#217 ·
Maintainers usually reply within 1 day
-
bug severity-medium XS
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
nikolas-charalambidis/facepalm-maven-plugin#291 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
OakLoaf/PluginUpdater#264 ·
Maintainers usually reply within 1 day
-
[Bug]: withStartupTimeout() changes the startup timeout of all containers that use the default wait strategyPossibly taken @aymenjamaaoui claimed this today. Opentype/bug
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
testcontainers/testcontainers-java#12171 ·
Maintainers usually reply within 1 day