Explicitly set `MaxDepth` when using `Newtonsoft.Json` for SignalR hub protocol
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 75/100
Research direction
The issue asks for the MaxDepth setting to be set explicitly in the SignalR hub protocol that uses Newtonsoft.Json, instead of inheriting the library default of 64. Start by finding where the System.Text.Json protocol already sets MaxDepth, and mirror that for the Newtonsoft path. Done means the Newtonsoft protocol sets the value explicitly and existing SignalR protocol tests still pass.
Written by the indexing model from the issue text.
Description
The SignalR hub protocol using Newtonsoft.Json currently relies on the default MaxDepth used by Newtonsoft.Json (64). Instead of relying on that package's default, we should explicitly set it - like we do when using System.Text.Json.
- Dominant language
- C#
- Stars
- 38.5k
- Forks
- 13.8k
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 227
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from dotnet/aspnetcore
-
area-minimal NativeAOT
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
dotnet/aspnetcore#69758 · 1 comment ·
Maintainers usually reply within 1 day
-
WebApplicationFactory sometimes throws ObjectDisposedException instead of the app's startup exceptionPossibly taken @Demivan claimed this 9 days ago. Openarea-mvc
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
dotnet/aspnetcore#69684 · 2 comments ·
Maintainers usually reply within 1 day
-
area-networking feature-httpsys
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
dotnet/aspnetcore#69671 · 1 comment ·
Maintainers usually reply within 1 day
-
.NET 10 OpenAPI emits an object constraint for floating-point valuesPossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
dotnet/aspnetcore#69604 · 1 comment ·
Maintainers usually reply within 1 day
-
Clarify Copilot guidance for framework-only invariants vs user-reachable validationPossibly taken @javiercn claimed this 16 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
dotnet/aspnetcore#69586 ·
Maintainers usually reply within 1 day
All issues in dotnet/aspnetcore
Similar issues
-
AzureBlobSnapshotStore.LoadAsync allocates the snapshot twice (growable MemoryStream + ToArray)Openenhancement
Difficulty 2/5 Half a day Newbie friendliness 72/100
-
bug ui-only
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
ClickHouse/clickhouse-cs#689 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 7 days
-
Difficulty 1/5 Under an hour Newbie friendliness 65/100
vchelaru/FlatRedBall2#1481 ·
Maintainers usually reply within 1 day