Align HttpSys caching with ResponseCaching checks
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 68/100
Research direction
Read the referenced checks in ResponseCachingPolicyProvider.cs and the caching logic in RequestContext.FeatureCollection.cs. Compare how they handle no-store and no-cache, then check the relevant HttpSys tests; done means HttpSys avoids caching when a non-caching directive is present, even if public is also set.
Written by the indexing model from the issue text.
Description
ResponseCaching checks values like no-store and no-cache when deciding whether a response should be cached.
https://github.com/dotnet/aspnetcore/blob/7eef82517d72081afab5a6d107f52f035340c6a1/src/Middleware/ResponseCaching/src/ResponseCachingPolicyProvider.cs#L68-L89
HttpSys currently relies on public, we should update the checks here to avoid any mistakes that could come from user error adding both public and a non-caching primitive.
https://github.com/dotnet/aspnetcore/blob/7eef82517d72081afab5a6d107f52f035340c6a1/src/Servers/HttpSys/src/RequestProcessing/RequestContext.FeatureCollection.cs#L727
- Dominant language
- C#
- Stars
- 38.5k
- Forks
- 12.5k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 217
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from dotnet/aspnetcore
-
.NET 10 OpenAPI emits an object constraint for floating-point valuesPossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
dotnet/aspnetcore#69604 · 1 comment ·
Maintainers usually reply within 1 day
-
Clarify Copilot guidance for framework-only invariants vs user-reachable validationPossibly taken @javiercn claimed this 6 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
dotnet/aspnetcore#69586 ·
Maintainers usually reply within 1 day
-
`EF Core UserStore.CreateUserPasskey` does not set `Aaguid`, so it's lost on passkey creationPossibly taken @MuhammadBilal64 claimed this 5 days ago. Openarea-identity
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
dotnet/aspnetcore#69495 · 1 comment ·
Maintainers usually reply within 1 day
-
area-identity feature-playwright 🎭 test-failure
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
dotnet/aspnetcore#69494 · 1 comment ·
Maintainers usually reply within 1 day
-
Blazor reconnect modal uses white instead of the system Canvas colorPossibly taken @oroztocil claimed this 15 days ago. Openarea-blazor feature-accessibility
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
dotnet/aspnetcore#69387 · 3 comments · 1 assignee ·
Maintainers usually reply within 1 day
All issues in dotnet/aspnetcore
Similar issues
-
[Doc Gap] Document new --enable-public-network-access breaking change for azurebackup vault createOpencopilot documentation
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
Maintainers usually reply within 1 day
-
area-dashboard
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
0 - Backlog Bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
BrighterCommand/Brighter#4539 ·
Maintainers usually reply within 1 day
-
triage
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Ignored test: FileLocalDataSourceTests.retries_loading_filePossibly taken A pull request linked to this issue is open or already merged. Opentest
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
NethermindEth/nethermind#14274 ·
Maintainers usually reply within 1 day