Import of Excel fails if the neutral resource file have been deleted
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 42/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- csharp
- Domain
- localization
Research direction
Start in src/ResXManager.Model/ResourceEntityExtensions.cs around lines 204-218, then follow the Excel import path for projects with localized resources but no neutral .resx file. Reproduce the listed steps and verify that importing skips the translation instead of failing, matching the behavior when all resource files are deleted.
Written by the indexing model from the issue text.
Description
Describe the bug
Resx Manager fails to import all translations when the neutral resource file have been deleted, but there still is a localized version.
MyResource.resx- MyResource.da.resx
To Reproduce
- Create a resource file with a single row
- Translate the row to another language
- Export an Excel file of all rows
- Delete the neutral resx file
- Import the Excel file
Expected behavior
I would expect the ResxManager to skip importing the translation, similar to how it works if all the Resource files are deleted.
I tried debugging this a bit, but I was unable to detect where I would need to make my changes.
But I believe the primary culprit is here: https://github.com/dotnet/ResXResourceManager/blob/647beb330ccb12f7283fb73b2fe29acf8d3c0c68/src/ResXManager.Model/ResourceEntityExtensions.cs#L204-L218
- Dominant language
- C#
- Stars
- 1.5k
- Forks
- 251
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 1
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from dotnet/ResXResourceManager
-
Feature request Up for grabs
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
dotnet/ResXResourceManager#777 ·
-
Feature request Up for grabs
Difficulty 3/5 1-2 days Newbie friendliness 68/100
dotnet/ResXResourceManager#778 ·
-
Feature request Up for grabs
Difficulty 4/5 3-5 days Newbie friendliness 48/100
dotnet/ResXResourceManager#762 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
dotnet/ResXResourceManager#758 · 5 comments ·
-
Feature request Up for grabs
Difficulty 3/5 1-2 days Newbie friendliness 55/100
dotnet/ResXResourceManager#747 · 3 comments ·
All issues in dotnet/ResXResourceManager
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
521xueweihan/HelloGitHub#3845 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
lay295/TwitchDownloader#1675 ·
-
copilot documentation
Difficulty 1/5 Under an hour Newbie friendliness 88/100
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
space-wizards/RobustToolbox#7119 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
dotnet/Scaffolding#3881 ·
Maintainers usually reply within 2 days