claude-executor: fail when claude-code-action skips itself
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 82/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- github-actions, yaml
- Domain
- ci-cd
Research direction
Open claude-executor.yml and find the claude-api and claude-bedrock steps, then compare with the equivalent check already merged in autodoc-executor.yml (#70). Add the guard step after each Claude step using the same skipped_due_to_workflow_validation_mismatch output condition, deciding between ::error::/exit 1 and ::warning:: based on the note about workflow-editing PRs. Done means a run where the action skips itself no longer reports green.
Written by the indexing model from the issue text.
Description
claude-code-action can skip without running Claude and still report success. It does this when the workflow file that triggered the run differs from the default branch's copy, and it signals the skip only through the skipped_due_to_workflow_validation_mismatch output. claude-executor.yml never checks that output.
The "Report internal SDK failure" step added in #61 doesn't catch it either. It checks is_error in the execution file, and a skip never starts a Claude turn, so there's no error to find. If the skip leaves execution_file empty, the step's if: condition skips it outright. The result is that a consumer PR that edits its own Claude workflow can go green without Claude having run.
claude-executor.yml correctly doesn't pass github_token, because it needs the App token for comments and signed commits. That's fine; the gap is only the missing check on the output.
Fix: add a step after each Claude step, like the one in autodoc-executor.yml (#70):
- name: Fail if the action skipped itself
if: steps.claude-api.outputs.skipped_due_to_workflow_validation_mismatch == 'true' || steps.claude-bedrock.outputs.skipped_due_to_workflow_validation_mismatch == 'true'
run: |
echo "::error::claude-code-action skipped (workflow validation) without running Claude"
exit 1
If failing would block legitimate workflow-editing PRs, emit ::warning:: instead.
Raised in review of #70.
- Dominant language
- No language data
- Stars
- 1
- Forks
- 0
- Avg merge
- 16m
- Merged PRs (30d)
- 1
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from dotCMS/ai-workflows
-
enhancement
Difficulty 1/5 Under an hour Newbie friendliness 85/100
dotCMS/ai-workflows#74 · 1 comment ·
-
documentation
Difficulty 1/5 Under an hour Newbie friendliness 86/100
dotCMS/ai-workflows#73 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
dotCMS/ai-workflows#42 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
dotCMS/ai-workflows#35 ·
-
enhancement
Difficulty 4/5 3-5 days Newbie friendliness 30/100
dotCMS/ai-workflows#75 ·
All issues in dotCMS/ai-workflows
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 90/100
GoogleCloudPlatform/gce-rescue#218 ·
Maintainers usually reply within 2 days
-
area:docs Bug
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Maintainers usually reply within 1 day
-
enhancement good-to-code
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
alvinunreal/oh-my-opencode-slim#1753 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
Maintainers usually reply within 1 day