tests: regression tests recommended by the performance audit are still missing

Closed
  • Is something wrong?
#1,616 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
40/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Tech stack
go
Domain
backend, testing

Research direction

This is a checklist of eight separate test gaps, so pick one item and treat it as its own change. The payload names internal/storage/attempt_epoch_integration_test.go:245 as the model for the migration round trip and internal/api/keyset_pagination_test.go as the place for the event log cursor error tests, which currently cover only TestDagRunsCursorRejectsGarbage. Done means each chosen test is committed and passes in CI, and the item is ticked off in this issue.

Written by the indexing model from the issue text.

Description

area/ci enhancement go priority/p2

The 2026-10-05 performance audit recommended these tests and the 2026-10-09 re-audit found none of them committed. Each one guards a fix that already shipped or a path that has no test today.

  • Unit tests for the wiring helpers that turn the gated performance settings on (#1445 added the E2E leg, the helpers themselves have none) (M-09).
  • MinIO-backed test of the segmented log layout (#1336).
  • Integration test for GetUserPrincipalByID with is_active=false (#1326; the audit's test passes but was never committed).
  • Parallel request test for the precompressed static assets (#1309).
  • Concurrent XCom RPC against an attempt spec drop (#1345, related to the spec cache resurrection Low).
  • Full down-migration round trip, from 026 to head and back to 026 (today only 038 has TestAttemptEpochMigrationUpDownUp, internal/storage/attempt_epoch_integration_test.go:245).
  • Event log cursor error paths: malformed cursor and repository error (M-24; internal/api/keyset_pagination_test.go covers only TestDagRunsCursorRejectsGarbage).
  • ListDagRunsPage integration test (goes with #1328).

The warm worker fail-closed branches and the warm pool E2E leg are tracked separately in #1611.

Dominant language
Go
Stars
46
Forks
1
Avg merge
10h 42m
Merged PRs (30d)
607

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dexadata/dexaflow

All issues in dexadata/dexaflow

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.