chart: no Helm value for auth.maxAttemptCredentialLifetime — extraEnv is the only route

Open Beginner friendly
  • Is something wrong?
#955 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
72/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Quiet
Tech stack
helm, kubernetes
Domain
devops

Research direction

Start with helm/leoflow/values.yaml and the extraEnv range in _controlplane-deployment.tpl, so the new value is stamped before that range. Add a 24h default with a doc comment, then add helm-unittest cases for the default, the extraEnv override, and a quoted set value. Run helm-docs -c helm/leoflow and replace the interim note in website/content/reference/configuration.md. Done when the tests pass and the reference shows the Helm: hint.

Written by the indexing model from the issue text.

Description

Gap

LEOFLOW_AUTH_MAX_ATTEMPT_CREDENTIAL_LIFETIME (ADR 0055) has no chart value:

$ grep -rn "maxAttemptCredentialLifetime\|MAX_ATTEMPT_CREDENTIAL_LIFETIME" helm/
(nothing)

No values.yaml entry, no stamped env var, and it is not in the deployment's guarded-variable list — so extraEnv reaches it, which is the only route an operator has today. That makes it the one ADR-0055 auth knob absent from the file operators read to discover what is tunable, and after #950 the only one in website/content/reference/configuration.md without a Helm: hint.

Split out of #950 deliberately: it takes a duration, not an enum, so the chart has to stamp a quoted "24h" and own the "a non-positive value disables the ceiling" story; it governs three behaviours; and #937 just moved its WARN semantics, so its documentation arc was in flight.

Scope

  • values.yaml entry with the 24h default and a doc comment covering the non-positive-disables case.
  • Stamp it in _controlplane-deployment.tpl before the extraEnv range, so an operator already setting it through the escape hatch keeps winning (same last-wins contract #950 pinned for secretScoping).
  • helm-unittest: default stamped; extraEnv override still last; a set value renders quoted.
  • helm-docs -c helm/leoflow, then replace the interim extraEnv only note in the configuration reference with Helm: auth.maxAttemptCredentialLifetime.

Not in scope

The chart-side enum guard for the three auth.* string values (a typo currently produces CrashLoopBackOff via internal/config/server.go:902-906, where the chart's convention elsewhere is to fail the render). That is a pre-existing symmetric gap and should be done for all of them at once.

Dominant language
Go
Stars
46
Forks
1
Avg merge
10h 42m
Merged PRs (30d)
607

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dexadata/dexaflow

All issues in dexadata/dexaflow

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.