Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

fix(review): validate criteria against the explicitly cited issue

Open
  • Is something wrong?
#1,109 1 comment 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

@devops-thiago is already working on this.

Since Oct 13, 2026.

  • #1112 by @devops-thiago — open

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
java
Domain
backend, testing

Research direction

Start with src/main/java/dev/thiagogonzaga/thrillhousebot/review/LinkedIssueCitations.java at the cited lines 177 and 368, then read the open pull request #1112 and its regression tests. Reproduce the linked billing and water-meter case and its controls against the pinned baseline. Done means an explicit issue citation only matches criteria in that issue's body, with the regression tests and the stated JDK 25 checks passing.

Written by the indexing model from the issue text.

Description

bug java

Background

Confirmed by the follow-up audit against main b82d391. Audit severity: LOW.

The complete open/closed issue inventory and all seven open PRs were checked; no existing ticket or PR covers this exact remaining behavior.

Reproduction evidence

With linked billing #228 and water-meter #231, a quote only present in #231 attributed explicitly to #228 is MATCHED. apply retains it and raises low risk/confidence to medium. Global linked-section matching fails to constrain explicit numbered finding citations; summary criterionHeld does isolate sections. Reproduced with exact current compiled classes in ParserScreenProbe, independently rerun by root. Only multiple linked issues trigger this case.

The audit exercised the current production implementation with the input and control cases above. The full baseline build passed 6,317 tests, Spotless, JaCoCo and SpotBugs; these edge cases were not covered by that suite.

Change required

An explicit issue number constrains matching and severity/confidence floors to that issue's own body. Another linked issue's matching criterion cannot validate the attribution.

Constraints

  • Preserve the existing positive and negative controls and the original fix from PR #1083.
  • Keep findings, code examples and supported input forms unless this ticket specifically requires filtering them.
  • Keep scans bounded without arbitrary silent omissions; preserve fail-open behavior where applicable.

Acceptance criteria

  • A behavioral regression test fails on the pinned baseline and passes with the fix for each reproduced case.
  • An explicit issue number constrains matching and severity/confidence floors to that issue's own body. Another linked issue's matching criterion cannot validate the attribution.
  • Existing regression tests remain green; changed production lines and branches are covered.
  • JDK 25: ./mvnw spotless:check and ./mvnw verify pass; CI and review findings are addressed.

References

Regression-test and fix-commit links will be added when the implementation PR is opened.

Dominant language
Java
Stars
35
Forks
7
Avg merge
9h 32m
Merged PRs (30d)
144

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from devops-thiago/ThrillhouseBot

All issues in devops-thiago/ThrillhouseBot

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.