bug(ci): a failed autoscaler inventory trial uploads no diagnostics

Open Beginner friendly
  • Is something wrong?
#7,700 0 comments 0 reactions 1 assignee View on GitHub

Maintainers usually reply within 1 day

@devantler is already working on this.

Since Oct 17, 2026.

  • #7827 by @devantler — open

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
70/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
github-actions, yaml
Domain
ci-cd, testing

Research direction

Read .github/actions/ksail-system-test/action.yaml and the action's README, including the note added in ksail#7699. Check how the system test phases and the failure diagnostics steps are ordered, then find the existing action step order test or add coverage there. Done means a failed autoscaler inventory trial leaves a diagnostics artifact, the test catches any test phase placed after diagnostics, and the outdated README note is removed.

Written by the indexing model from the issue text.

Description

🤖 Generated by the Agentic Engineer

Problem

When the Hetzner autoscaler inventory trial fails in the system-test action, the failure diagnostics are not saved or uploaded. Someone reading the failed run gets the job log only, without the cluster state the other phases leave behind.

Evidence

In .github/actions/ksail-system-test/action.yaml on main:

  • 📋 Save system test diagnostics and 📤 Upload system test diagnostics run on failure() and come first;
  • 📦 Setup hcloud for autoscaler inventory trial and 🧪 Hetzner autoscaler inventory — unchanged update and retry come after them.

So when the trial is the first step to fail, both diagnostics steps have already been skipped. Found by a review of ksail#7699, which documents the current order instead of changing it.

Expected

A failed autoscaler inventory trial leaves the same diagnostics artifact as any other failed phase.

Acceptance criteria

  • The trial runs before the diagnostics steps, or the diagnostics steps run again after it.
  • A test of the action's step order fails if a test phase is placed after the diagnostics steps.
  • The note added to .github/actions/ksail-system-test/README.md in ksail#7699 ("runs after this phase") is removed.
Dominant language
Go
Stars
166
Forks
13
Avg merge
7h 4m
Merged PRs (30d)
388

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from devantler-tech/ksail

All issues in devantler-tech/ksail

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.