api: use Domain.select_for_update() to prevent races
Maintainers usually reply within 14 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- Half a day
- Newbie friendliness
- 45/100
Research direction
Start from commit 1c25419e7e0ed4a0be0fd6b50bdcd7997177632f, which the issue names as the source of the race, and find the code path where a Domain is read and then modified without a row lock. The fix is to lock the Domain row with select_for_update() inside a transaction at that point. Done when the racy path takes the lock and the existing API tests still pass.
Written by the indexing model from the issue text.
Description
for fixing 1c25419e7e0ed4a0be0fd6b50bdcd7997177632f at the root
- Dominant language
- Python
- Stars
- 678
- Forks
- 74
- Avg merge
- 7d 23h
- Merged PRs (30d)
- 1
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from desec-io/desec-stack
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
desec-io/desec-stack#1312 ·
Maintainers usually reply within 14 days
-
UI bug and inconsistency: Adding IPv6 address/netmask to token IP restriction silently errors outOpen
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
desec-io/desec-stack#1310 ·
Maintainers usually reply within 14 days
-
Here-strings in request examplesPossibly taken @jadhavgaurav claimed this 28 days ago. Opendocs help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
desec-io/desec-stack#1286 · 1 comment ·
Maintainers usually reply within 14 days
-
api enhancement prio: low
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
desec-io/desec-stack#1246 · 1 comment ·
Maintainers usually reply within 14 days
-
enhancement gui help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
desec-io/desec-stack#1181 · 1 comment ·
Maintainers usually reply within 14 days
All issues in desec-io/desec-stack
Similar issues
-
[dbt] exported dataset keys reference physical columnsPossibly taken @WilliamKelley claimed this today. Openneeds-triage
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
apache/ossie-converters#251 ·
Maintainers usually reply within 2 days
-
cli difficulty: easy enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 2 days
-
needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
aws/aws-durable-execution-sdk-python#977 ·
Maintainers usually reply within 1 day
-
needs-triage
Difficulty 1/5 Under an hour Newbie friendliness 88/100
flashinfer-ai/flashinfer#9803 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
iamprivacy/Waves#66 · 2 comments ·