[CI]: test-scripts skips two test files, and one of them fails

Open Beginner friendly
#977 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
82/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
github-actions, python
Domain
ci-cd, testing

Research direction

Start with .github/workflows/test-parser.yml and the .github/scripts/tests directory. Update test_subject_uppercase in test_lintcommit.py to match the rule change described in the issue, then run python -m pytest .github/scripts/tests. Done means the test-scripts job runs the whole directory and that command passes.

Written by the indexing model from the issue text.

Description

needs-triage

Found while working on Python #971: add PR status labels and bump issue triage.

Problem

The test-scripts job in test-parser.yml runs a fixed list of test files, so a new file under .github/scripts/tests runs in CI only after someone adds it to the list. No other job runs these files, because the pytest testpaths setting lists only packages/*/tests directories.

Two files are not on the list, so CI does not run them:

Change
  • Change test_subject_uppercase to expect no error, since uppercase subjects are allowed on purpose.
  • Run the whole .github/scripts/tests directory in test-scripts instead of the list, so a new test file runs without a list edit.
Acceptance criteria
  • test-scripts runs every test file under .github/scripts/tests.
  • python -m pytest .github/scripts/tests passes on main.
Dominant language
Python
Stars
59
Forks
32
Avg merge
1d 5h
Merged PRs (30d)
76

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from aws/aws-durable-execution-sdk-python

All issues in aws/aws-durable-execution-sdk-python

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.