Hacktoberfest 2026: die Issues, die Maintainer für den Oktober markiert haben – offen und einsteigerfreundlich. Hacktoberfest-Issues durchsuchen

Perf: add in-process timing instrumentation to replace py-spy dependency

Offen
  • Stimmt etwas nicht?
#140 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
46/100
Issue-Typ
Feature
Klarheit
Größtenteils klar
Aktivitätsstatus
Veraltet
Tech-Stack
python
Bereich
performance

Rechercherichtung

Start by reading read_xarray_table and _iteration_callback in the reader, then inspect perf_tests/profile.sh and perf_tests/query_large_synthetic.py to understand the current profiling workflow. Choose and implement a timing approach that reports per-partition costs across the relevant execution stages. Confirm the measurements distinguish I/O, conversion, and DataFusion work without requiring py-spy or root access.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

Problem

The current profiling workflow in perf_tests/ requires py-spy, which needs sudo on macOS:

sudo ./profile.sh groupby_air_full.py

This makes profiling unavailable in many CI environments and for users without root access. Additionally, cProfile only sees the Python side of query execution — the entire DataFusion execution appears as a single opaque to_arrow_table() call (0.66s for 320 MB of data in our benchmarks), making it impossible to distinguish:

  • Time spent in xarray I/O (ds.isel(block), .values)
  • Time spent in numpy → Arrow conversion (iter_record_batches)
  • Time spent in DataFusion (aggregation, hash-grouping, row filtering)
  • Time spent waiting for GIL between partitions

Proposed solution

Add a lightweight per-partition timing mode to the _iteration_callback mechanism already in read_xarray_table:

# reader.py — extend make_stream to record timing
def make_stream(projected_names=None) -> pa.RecordBatchReader:
    if _timing_callback is not None:
        t0 = time.perf_counter()
    result = pa.RecordBatchReader.from_batches(...)
    if _timing_callback is not None:
        _timing_callback({"elapsed_s": time.perf_counter() - t0, "block": block})
    return result

Or alternatively: add a verbose=True flag to read_xarray_table that prints per-partition timings to stderr, giving insight into whether execution is I/O-bound or compute-bound without requiring external tools.

A lower-overhead option is to expose a PartitionTimingHook via LazyArrowStreamTable that fires before/after each factory call.

Current profiling workaround

For the query_large_synthetic.py benchmark (320 MB, 8 partitions):

Full scan AVG:    0.662s  (341 MB peak)   ← all in Rust's to_arrow_table()
Filter pushdown:  0.005s  (0.7 MB peak)   ← 7/8 partitions pruned
GROUP BY lat/lon: 0.839s  (341 MB peak)   ← +27% vs. AVG for hash aggregation

cProfile shows 246 Python calls for the full scan, but 0.660s of those are attributed to {method 'to_arrow_table' of 'datafusion.DataFrame' objects} — a Rust builtin that cProfile cannot introspect.

Related

  • _iteration_callback in XarrayRecordBatchReader and read_xarray_table — already used for testing
  • perf_tests/profile.sh — current py-spy based approach
  • perf_tests/query_large_synthetic.py — new benchmark script added alongside this issue
Vorherrschende Sprache
Python
Sterne
142
Forks
19
Ø Merge
1 T. 9 Std.
Gemergte PRs (30 T.)
9

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus xqlsystems/xarray-sql

Alle Issues in xqlsystems/xarray-sql

Ähnliche Issues

Weitere Issues zu Python

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.