Hacktoberfest 2026: die Issues, die Maintainer für den Oktober markiert haben – offen und einsteigerfreundlich. Hacktoberfest-Issues durchsuchen

Negative `input` pattern is ignored for files discovered via `readdir`

Offen
  • Stimmt etwas nicht?
#504 3 Kommentare 1 Reaktion 1 zugewiesene Person Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

@wan9chi arbeitet bereits daran.

Seit 03.7.2026.

Bewertung

Dieses Issue wurde noch nicht bewertet.

Beschreibung

Summary

A negative input pattern ("!path") correctly excludes a file a task reads by direct path, but does not exclude a file the task discovers through a directory listing (readdir). When such a file is a build artifact that is absent on a fresh checkout, its removal invalidates the cache with Removed, so the cache never hits, even though a negative pattern for that exact path is present.

Reproduction

https://github.com/why-reproductions-are-required/vite-task-negative-input-pattern-readdir

pnpm install
./repro.sh

The repro defines two tasks that differ only in how they discover an excluded, generated artifact:

// BUG: artifact found via readdir("assets")
"readdir-case": {
  command: "node -e \"fs.readdirSync('assets'); fs.writeFileSync('assets/generated.txt', ...)\"",
  input: [{ auto: true }, "!assets/generated.txt"],
},
// CONTROL: artifact read by direct path
"direct-path-case": {
  command: "node -e \"try { fs.readFileSync('direct.txt') } catch {}; fs.writeFileSync('direct.txt', ...)\"",
  input: [{ auto: true }, "!direct.txt"],
},

Expected vs actual

Each task is run 3 times; run 3 removes the excluded artifact before running. Removing an excluded file should keep the cache valid.

task discovery run 3 result
direct-path-case readFileSync HIT (correct)
readdir-case readdirSync MISS: InputChanged { Removed, "assets/generated.txt" }

Only the discovery method differs.

Impact

Real builds routinely list a directory that also contains generated files. In a Vite + void app the build lists directories holding .void/queues.d.ts, .void/routes.d.ts, public/feed.xml, public/sitemap.xml, public/posts/, etc. On a fresh CI checkout those files do not exist yet, so the cache misses on every run even with a negative pattern for each of them. The only workaround I found is to abandon { auto: true } and enumerate every input explicitly.

Possibly related

crates/vite_task/src/session/execute/fingerprint.rs notes that negative-glob filtering for the post-run fspy fingerprint is "done upstream" and that paths already in globbed_inputs are skipped; PathRead { read_dir_entries: bool } distinguishes directory-listing reads. The negative filter appears not to reach entries surfaced by a directory listing.

Environment

  • vite-plus 0.2.2 (bundles Vite Task)
  • Reproduced on macOS (darwin 25.x) and GitHub Actions ubuntu-latest
Vorherrschende Sprache
Rust
Sterne
473
Forks
44
Ø Merge
1 T. 1 Std.
Gemergte PRs (30 T.)
63

Entwicklungsumgebung

In Codespaces öffnen

Startet den Dev-Container des Projekts im Browser, mit Ihrem eigenen GitHub-Konto.

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus voidzero-dev/vite-task

Alle Issues in voidzero-dev/vite-task

Ähnliche Issues

Weitere Issues zu Rust

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.