Support external `vp-<command>` executables, as Git and Cargo do

Geschlossen
  • Stimmt etwas nicht?
#3,195 0 Kommentare 0 Reaktionen 1 zugewiesene Person Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

@cpojer arbeitet bereits daran.

Seit 22.10.2026.

Bewertung

Dieses Issue wurde noch nicht bewertet.

Beschreibung

enhancement pending triage

Problem

Workspace tool authors cannot expose a command such as vp pr gen: the global
CLI rejects pr before the workspace's JavaScript implementation can run.
Today our workspace runs the same tool with vp exec vpp pr gen.

Reproduction

With an executable named vp-pr installed in the workspace's node_modules/.bin,
vp pr --help should be able to run that executable with --help. With Vite+
1.3.0 installed, the current command exits 2 with error: Command 'pr' not found.
Patching the local dist/bin.js dispatcher does not help: it is never reached.

Checked source

Inspected the official repository at commit
733b973ebe26f097ebe007cb079b2ee64b2f7217 in ~/repo-references/vite-plus:

  • main.rs:522
    calls try_parse_args_from before command execution.
  • main.rs:537
    handles InvalidSubcommand as an error/suggestion. Only the successful parse
    arm reaches run_command at line 583.
  • cli.rs:69
    declares the closed Commands enum. It has no external-subcommand arm.
  • cli.rs:1298
    calls clap's try_get_matches_from and Args::from_arg_matches.
  • cli.rs:1179
    already routes exec through the managed local executable path.

Proposal

Support Git/Cargo-style external subcommands: when no built-in matches foo,
resolve vp-foo using the same managed runtime and workspace executable
resolution as vp exec, then forward the remaining argv unchanged.

Built-ins retain precedence. Unknown names still fail with the existing useful
error when no executable exists. No implicit package download or install is
needed. Preserve cwd, -C, stdout/stderr, exit status, signals, --, and platform
executable/shim behavior. A locally installed extension should be explicitly
available in the workspace, not inferred from a matching package name.

This gives workspace extensions a natural command without modifying Vite+'s
built-in command set or maintaining an unreachable JavaScript dispatch patch.

Suggested acceptance cases

  • vp foo a --flag -- value executes vp-foo with exact argument boundaries.
  • Existing built-ins win over a same-name executable.
  • Workspace executable resolution and -C behave like vp exec.
  • Missing executable retains the unknown-command error; no download occurs.
  • Child exit code and termination signals propagate.
  • Unix executables and Windows executable shims both work.
Vorherrschende Sprache
Rust
Sterne
6.5k
Forks
297
Ø Merge
20 Std. 18 Min.
Gemergte PRs (30 T.)
236

Entwicklungsumgebung

In Codespaces öffnen

Startet den Dev-Container des Projekts im Browser, mit Ihrem eigenen GitHub-Konto.

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus voidzero-dev/vite-plus

Alle Issues in voidzero-dev/vite-plus

Ähnliche Issues

Weitere Issues zu Rust

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.