[Bug] Admin IPC accepts malformed request bytes that admin HTTP rejects

Offen
  • Stimmt etwas nicht?
#7,044 4 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
70/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
java
Bereich
backend-api-design

Rechercherichtung

Read IpcRequestHandler.readRequest, IpcService.handleClient, and IpcRequestHandler.handleCommand, then compare their input handling with AdminRpcServlet and AdminJsonRpcRequestHandler.handleRequest. Reproduce the malformed-byte request using the commands in the issue. Done means IPC and admin HTTP reject the same invalid UTF-8 or surrounding control characters with -32700, without calling the method.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

Bug Description

Admin IPC changes a request's bytes before it parses them. Invalid UTF-8 inside the request is replaced with U+FFFD, and control characters before or after the JSON object are removed, so admin_example runs with input the client didn't send. Admin HTTP passes the same bytes to the parser unchanged and returns -32700.

Environment

Network
Mainnet configuration, local node started with --p2p-disable true

Software Versions

OS: Fedora 44, Linux 7.2.9-200.fc44.x86_64
JVM: Temurin 1.8.0_504 amd64
Git Commit: 2d99513742d92af4f7b5f68791d809582a9e4549
Version: 4.8.2.3
Code: 18830

Configuration
FullNode built from release_v4.8.3 with the shipped config.conf plus node.admin.ipc.enable = true and node.admin.http.enable = true.

Expected Behavior

The same request bytes get the same reply over IPC and admin HTTP. A request that isn't valid UTF-8 JSON gets -32700 and the method isn't called.

Actual Behavior

Over IPC, a request with an 0xff byte inside a string runs admin_example and returns a result with U+FFFD where the 0xff byte was. Over admin HTTP the same bytes return -32700. A truncated UTF-8 sequence behaves the same way. A NUL after the object or a vertical tab before it also succeeds over IPC and returns -32700 over HTTP. The node logs nothing for any of these IPC requests.

Frequency

  • Always (100%)
  • Frequently (>50%)
  • Sometimes (10-50%)
  • Rarely (<10%)

Steps to Reproduce

  1. Start a FullNode with node.admin.ipc.enable = true and node.admin.http.enable = true.
  2. Send a request with an 0xff byte inside a string over IPC, then the same bytes to admin HTTP.
printf '{"jsonrpc":"2.0","method":"admin_example","params":["a\xffb","b"],"id":7}\n' | socat - UNIX-CONNECT:output-directory/ipc/<pid>.sock
printf '{"jsonrpc":"2.0","method":"admin_example","params":["a\xffb","b"],"id":7}' | curl -s -H 'Content-Type: application/json' --data-binary @- http://127.0.0.1:8575/admin

Logs and Error Messages

IPC   {"jsonrpc":"2.0","id":7,"result":"a�b:b"}
HTTP  {"jsonrpc":"2.0","id":null,"error":{"code":-32700,"message":"JSON parse error"}}

The � in the IPC reply is U+FFFD, sent as the bytes EF BF BD.

Additional Context (Optional)

Possible Solution
IpcRequestHandler.readRequest decodes the line into a String, IpcService.handleClient trims it, and IpcRequestHandler.handleCommand encodes it again before calling AdminJsonRpcRequestHandler.handleRequest. AdminRpcServlet calls the same method with the raw body. Passing the IPC line bytes straight through, without the trim, gives both transports the same input.

Vorherrschende Sprache
Java
Sterne
4.2k
Forks
1.8k
Ø Merge
2 T. 15 Std.
Gemergte PRs (30 T.)
41

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus tronprotocol/java-tron

Alle Issues in tronprotocol/java-tron

Ähnliche Issues

Weitere Issues zu Java

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.