Incorrect lagged income quintiles after benefit-unit changes
Dieses Issue hat noch niemand übernommen.
Bewertung
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Anfängerfreundlichkeit
- 45/100
Rechercherichtung
Start with Person.getYHhQuintilesMonthC5L1() in src/main/java/simpaths/model/Person.java, the Q2–Q5 dummy getters, and new benefit unit initialization in src/main/java/simpaths/model/BenefitUnit.java. Trace how a person's benefit unit changes and decide how individual lagged quintile history should be retained, including how missing history is handled. Add focused checks for unchanged membership, a new unit at age 18, and partnership formation between people with different quintiles.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
Coding problem
A person's lagged income quintile should describe the benefit unit they belonged to in the previous period. Instead, Person.getYHhQuintilesMonthC5L1() reads the lag stored on their current benefit unit:
return benefitUnit.getYHhQuintilesMonthC5L1();
When someone forms a new benefit unit, for example on turning 18 or forming a partnership, that unit may have no previous-period quintile. The Q2-Q5 dummy getters then all return zero, silently applying the Q1 reference-category coding. This is not evidence that the person was previously in Q1.
The new-unit initialisation supplies Q3 for a missing current quintile, but does not restore the person's previous quintile.
Verification
In a clean build of develop at 11bec2bd9 (23 October), an isolated getter test returned:
- Original benefit unit with lagged Q5: Q5.
- Membership changed to a new unit without history: null, with all Q2-Q5 dummy values 0.
- Destination unit given lagged Q2: Q2, rather than the person's original Q5.
The same behaviour occurs in the saved income-validation JAR. These checks establish the getter problem; they do not measure its population frequency or aggregate effect on predictions.
Proposed coding repair
The approach discussed was to preserve each person's BU income quintile at the individual level before membership changes, and use that stored previous-period value for the lagged regressor. Two people forming a couple could then correctly retain different lagged quintiles. Retaining the previous BU link and its historical value is an alternative.
A focused test would check unchanged membership, a new BU at age 18, and partnership formation between people from different quintiles. Missing history would also need explicit handling rather than silently becoming the reference category. This repair preserves the meaning of the existing regressor; it does not itself require replacing it with parental income.
Separate education-specification question
Even with the coding repair, a student may subsequently have low own-BU income while still living with well-off parents. Whether E1a should instead use parental income, and how E1b should distinguish own from parental resources, is a separate specification decision requiring consistent estimation and Java implementation.
This issue is about preserving individual history, not choosing those education specifications or imputing parental income. It is also distinct from the equivalence-scale error in #541.
Could we confirm the preferred implementation and who will take it forward?
- Vorherrschende Sprache
- Java
- Sterne
- 26
- Forks
- 38
- Ø Merge
- 13 Std. 5 Min.
- Gemergte PRs (30 T.)
- 7
Entwicklungsumgebung
Dieses Projekt bietet weder Dev-Container noch Dockerfile noch Beitragsleitfaden – die Einrichtung liegt bei Ihnen. Beginnen Sie mit der README; die allgemeinen Schritte stehen in unserem Leitfaden für den ersten Beitrag.
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus simpaths/SimPaths
-
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 89/100
-
bug
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 65/100
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 62/100
-
F1: fertility-rate predictor inconcistency between estimation and Java implementationEvtl. vergeben @dariaple hat das vor 4 Tagen übernommen. Offen
-
H2: should dlltsd01 be set to zero for retirees?Evtl. vergeben @Kolndre hat das vor 6 Tagen übernommen. Offen
Alle Issues in simpaths/SimPaths
Ähnliche Issues
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 72/100
geonetwork/core-geonetwork#9592 ·
Maintainer antworten meist innerhalb von 2 Tagen
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 63/100
Maintainer antworten meist innerhalb von 1 Tag
-
[Bug] ServerHttpRequest.getURI() throws NumberFormatException when Host contains an explicit portOffencomponent/need-triage type/need-triage
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 76/100
Maintainer antworten meist innerhalb von 1 Tag
-
bug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 72/100
apache/rocketmq-dashboard#7361 ·
Maintainer antworten meist innerhalb von 3 Tagen
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
higress-group/himarket#358 ·