[Bug] LintEngine duplicates built-in diagnostics across repeated runs

Offen
  • Stimmt etwas nicht?
#99 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

@amazingjoe arbeitet bereits daran.

Seit 06.11.2026.

  • #105 von @amazingjoe — offen

Bewertung

Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
72/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
node.js, typescript
Bereich
backend, tooling

Rechercherichtung

Start by tracing LintEngine.run() and walkNode() where prior diagnostics are cleared, then inspect requiredFieldPass() and lintDiagnostic() to compare their source tags. Add or adapt a regression test using the repeated-run reproduction, including disabling the rule; done when it reports [1, 1, 1, 0] and the test passes.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

Description

Running the exported LintEngine repeatedly on the same AST accumulates diagnostics from built-in rules when the engine uses its default source tag. Disabling the rule also leaves the old diagnostics in the result. This conflicts with run()'s documented behavior of clearing prior diagnostics so re-runs produce fresh results.

Steps to Reproduce

  1. Check out upstream main at ace15eb2dc75564fd9e214385ac045c539056770 and install the locked dependencies.

  2. Build the JavaScript parser and language packages:

    pnpm --filter @agentscript/types --filter @agentscript/parser-javascript --filter @agentscript/parser --filter @agentscript/language -r run build

  3. Run the reproduction below from the repository root with node --input-type=module.

Expected Behavior

Each run reports exactly one missing-target diagnostic. After disabling the rule, the next run reports none: [1, 1, 1, 0].

Actual Behavior

The result is [1, 2, 3, 3]. Every entry is the same missing-required-field error for target, with source agentscript-lint. No lint-pass-error diagnostic occurs.

Environment

  • Node.js version: 22.20.0
  • pnpm version: 10.34.6
  • OS: macOS 27.0.1, arm64
  • Package & version: @agentscript/language 3.10.4, source checkout at the commit above

Minimal Reproduction

import { parse } from './packages/parser/dist/index.js';
import {
  ActionsBlock,
  Dialect,
  LintEngine,
  createSchemaContext,
  requiredFieldPass,
} from './packages/language/dist/index.js';

const schema = { actions: ActionsBlock };
const context = createSchemaContext({ schema, aliases: {} });
const root = parse(`
actions:
  Notify_Manager:
    description: "Notify the store manager"
`).rootNode;
const mapping = root.namedChildren.find(n => n.type === 'mapping') ?? root;
const ast = new Dialect().parse(mapping, schema).value;
const rule = requiredFieldPass();
const engine = new LintEngine({ passes: [rule] });
const count = () => engine.run(ast, context).diagnostics.filter(
  d => d.code === 'missing-required-field'
).length;

const counts = [count(), count(), count()];
engine.disable(rule.id);
counts.push(count());
console.log(counts); // [1, 2, 3, 3]

Additional Context

LintEngine defaults its source tag to lint, and walkNode() only clears diagnostics whose source matches that tag. Built-in rules such as requiredFieldPass() instead use the hard-coded agentscript-lint tag through lintDiagnostic(). A custom engine source such as test reproduces the same accumulation.

As a control, constructing the engine with source: 'agentscript-lint' yields [1, 1, 1, 0] on the same input. All reproduction and control assertions ran offline; no fix is included.

Vorherrschende Sprache
TypeScript
Sterne
275
Forks
57
Ø Merge
2 T. 1 Std.
Gemergte PRs (30 T.)
6

Entwicklungsumgebung

In Codespaces öffnen

Startet den Dev-Container des Projekts im Browser, mit Ihrem eigenen GitHub-Konto.

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus salesforce/agentscript

Alle Issues in salesforce/agentscript

Ähnliche Issues

Weitere Issues zu TypeScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.