Regression: IntegerNode values are incorrect after syntax errors
Maintainer antworten meist innerhalb von 1 Tag
Ein zugehöriger Pull Request wurde bereits gemerged.
- #4332 von @kddnewton — gemerged
Bewertung
- Schwierigkeit
- 3/5
- Geschätzter Aufwand
- 1-2 Tage
- Anfängerfreundlichkeit
- 57/100
Rechercherichtung
Start by reproducing the incorrect IntegerNode values with Prism 2.1.0 using the examples Prism.parse("1 2 3") and Prism.parse("1i 2i 3i"), then compare the relevant parser behavior with Prism 1.9.0. The issue does not name source files or tests, so trace integer literal parsing and its regression coverage from the parser entry point. Done means each IntegerNode retains the value at its own source location, including when syntax errors are present.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
Affected version: Prism 2.1.0
Known working version: Prism 1.9.0
In Prism 2.1.0, parsing consecutive integer literals separated by whitespace produces an AST with incorrect values for some IntegerNode instances.
Reproduction
Prism.parse("1 2 3")
Prism.parse("1i 2i 3i")
In Prism 2.1.0, the resulting AST contains:
@ StatementsNode (location: (1,0)-(1,5))
├── flags: ∅
└── body: (length: 3)
├── @ IntegerNode (location: (1,0)-(1,1))
│ ├── flags: newline, static_literal, decimal
│ └── value: 2
├── @ IntegerNode (location: (1,2)-(1,3))
│ ├── flags: newline, static_literal, decimal
│ └── value: 2
└── @ IntegerNode (location: (1,4)-(1,5))
├── flags: newline, static_literal, decimal
└── value: 3,
@ StatementsNode (location: (1,0)-(1,8))
├── flags: ∅
└── body: (length: 3)
├── @ ImaginaryNode (location: (1,0)-(1,2))
│ ├── flags: newline, static_literal
│ └── numeric:
│ @ IntegerNode (location: (1,0)-(1,1))
│ ├── flags: static_literal, decimal
│ └── value: 2
├── @ ImaginaryNode (location: (1,3)-(1,5))
│ ├── flags: newline, static_literal
│ └── numeric:
│ @ IntegerNode (location: (1,3)-(1,4))
│ ├── flags: static_literal, decimal
│ └── value: 3
└── @ ImaginaryNode (location: (1,6)-(1,8))
├── flags: newline, static_literal
└── numeric:
@ IntegerNode (location: (1,6)-(1,7))
├── flags: static_literal, decimal
└── value: 3,
The first node represents the literal 1, but its value is 2.
FloatNode and RationalNode nodes generate correct values in a similar case.
Comparison with Prism 1.9.0
This behavior does not occur in Prism 1.9.0.
@ StatementsNode (location: (1,0)-(1,5))
├── flags: ∅
└── body: (length: 3)
├── @ IntegerNode (location: (1,0)-(1,1))
│ ├── flags: newline, static_literal, decimal
│ └── value: 1
├── @ IntegerNode (location: (1,2)-(1,3))
│ ├── flags: newline, static_literal, decimal
│ └── value: 2
└── @ IntegerNode (location: (1,4)-(1,5))
├── flags: newline, static_literal, decimal
└── value: 3,
@ StatementsNode (location: (1,0)-(1,8))
├── flags: ∅
└── body: (length: 3)
├── @ ImaginaryNode (location: (1,0)-(1,2))
│ ├── flags: newline, static_literal
│ └── numeric:
│ @ IntegerNode (location: (1,0)-(1,1))
│ ├── flags: static_literal, decimal
│ └── value: 1
├── @ ImaginaryNode (location: (1,3)-(1,5))
│ ├── flags: newline, static_literal
│ └── numeric:
│ @ IntegerNode (location: (1,3)-(1,4))
│ ├── flags: static_literal, decimal
│ └── value: 2
└── @ ImaginaryNode (location: (1,6)-(1,8))
├── flags: newline, static_literal
└── numeric:
@ IntegerNode (location: (1,6)-(1,7))
├── flags: static_literal, decimal
└── value: 3,
Expected behavior
Each IntegerNode should retain the value corresponding to its own source location, even when the input contains syntax errors.
Since Prism 1.9.0 handled these cases correctly, this appears to be a regression introduced in a later version.
- Vorherrschende Sprache
- C
- Sterne
- 1k
- Forks
- 202
- Ø Merge
- 7 Std. 52 Min.
- Gemergte PRs (30 T.)
- 76
Entwicklungsumgebung
- Kein Dockerfile und keine Docker-Compose-Datei
- Keine Pull-Request-Vorlage
- Beitragsleitfaden lesen
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Ähnliche Issues
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
Maintainer antworten meist innerhalb von 1 Tag
-
contrib/ivorysql_ora/src/builtin_packages/utl_file/utl_file.c:517 - FCOPY destroys a file when source and destination are the sameEvtl. vergeben @Metastarx hat das heute übernommen. Offen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 75/100
ly05010419/MacNativeGames#1848 ·
Maintainer antworten meist innerhalb von 1 Tag
-
libc++ test-suite
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 85/100
llvm/llvm-project#239851 ·
Maintainer antworten meist innerhalb von 1 Tag