Infinity Loop with `Capture ** Screenshot` when using `{{index}}` (escaped) while file exists
@emanlove arbeitet bereits daran.
Seit 20.1.2024.
Bewertung
Dieses Issue wurde noch nicht bewertet.
Beschreibung
The following atest should be updated to this, so that the screenshot is taken twice.
Capture page screenshot with escaped braces
${file} = Capture Page Screenshot ${OUTPUTDIR}/screenshot-and-index/brackets-{{index}}-name.png
File Should Exist ${OUTPUTDIR}/screenshot-and-index/brackets-{index}-name.png
${file} = Capture Page Screenshot ${OUTPUTDIR}/screenshot-and-index/brackets-{{index}}-name.png # this line is new!
Should Be Equal ${file} ${OUTPUTDIR}${/}screenshot-and-index${/}brackets-{index}-name.png
${file} = Capture Page Screenshot ${OUTPUTDIR}/screenshot-and-index/brackets-{{index-name.png
File Should Exist ${OUTPUTDIR}/screenshot-and-index/brackets-{index-name.png
The problem is, that the code of _get_screenshot_path() does increment the index and then checks if either the (original) filename is equal to the formatted filename, which would mean that there was no {index} in it, or the file does not exists.
So that mean if the filename is before and after formatting the same, it does not matter if it exists, it will be overwritten.
BUT there is one special feature, that you can include {index} in the final file name, by doubling the braces.
So filename-{{index}}.png will be filename-{index}.png in the filesystem.
The problem now is, that the original filename (filename-{{index}}.png) is not equal with the formatted filename filename-{index}.png and therefore the index is increased. But there is no replaceable index in the original name, so the while loop is infinit.
The fix would be to compare not the original with the formatted, but two formatted with different index numbers with each other.
This is the fixed code:
def _get_screenshot_path(self, filename):
if self._screenshot_root_directory != EMBED:
directory = self._screenshot_root_directory or self.log_dir
else:
directory = self.log_dir
filename = filename.replace("/", os.sep)
index = 0
while True:
index += 1
formatted = _format_path(filename, index)
formatted_control = _format_path(filename, sys.maxsize) # control group with max int
path = os.path.join(directory, formatted)
# filename didn't contain {index} or unique path was found
if formatted == formatted_control or not os.path.exists(path): # two formatted texts are compared.
return path
kind regards
René
- Vorherrschende Sprache
- Python
- Sterne
- 1.5k
- Forks
- 787
- PR-Merge-Kennzahlen
- Keine gemergten PRs in 30 T.
Beitragsleitfaden
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus robotframework/SeleniumLibrary
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 67/100
robotframework/SeleniumLibrary#1941 · 3 Kommentare ·
-
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 65/100
robotframework/SeleniumLibrary#1833 ·
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 68/100
robotframework/SeleniumLibrary#1436 · 5 Kommentare ·
-
Schwierigkeit 3/5 1-2 Tage Anfängerfreundlichkeit 58/100
robotframework/SeleniumLibrary#1993 ·
-
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 35/100
robotframework/SeleniumLibrary#1992 · 4 Kommentare ·
Alle Issues in robotframework/SeleniumLibrary
Ähnliche Issues
-
agent-ready documentation needs-triage
Schwierigkeit 1/5 1-3 Stunden Anfängerfreundlichkeit 88/100
-
documentation
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 91/100
-
workflow-status page template still says reusable workflows are "triggered only by workflow_call:" Offen
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 92/100
-
instance instance add
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 72/100
searxng/searx-instances#939 · 1 Kommentar ·
-
area-deployment area-integrations triage:bot-seen
Schwierigkeit 2/5 Ein halber Tag Anfängerfreundlichkeit 86/100