Metrics follow-ups from the operator-signals review: BReg scrape lock, offline check depth
Maintainer antworten meist innerhalb von 1 Tag
Dieses Issue hat noch niemand übernommen.
Bewertung
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Anfängerfreundlichkeit
- 45/100
- Issue-Typ
- Bug
- Klarheit
- Größtenteils klar
- Aktivitätsstatus
- Aktiv
- Tech-Stack
- prometheus, rust
- Bereich
- backend, observability
Rechercherichtung
Start in crates/registry-breg/src/metrics.rs at with_scrape_deadline and trace where the queue_sample lock is taken relative to the ScrapeDeadline, then look at the Adapter job host's sample cache as the reference for sharing one in-flight sample between concurrent scrapes. For part 2, find the offline configuration check in the Evidence and Adapter crates and compare how they decode metricsListener.networkExposure against a product that substitutes the stand-in (BReg or Casework). Done means two concurrent scrapes stay within scrape_timeout on a slow database, and Evidence/Adapter keep checking the rest of the file past an ${ENV} value.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
Two follow-ups from the review of #2745 (operator signals). Neither blocks it.
1. BReg: a second concurrent scrape can exceed the scrape timeout when the database is slow
crates/registry-breg/src/metrics.rs, with_scrape_deadline, holds the queue_sample lock for the whole sample. It starts the 5 second ScrapeDeadline only once the lock is held, by design: lock contention never counts as a failed read.
With two Prometheus servers scraping the same BReg (a common high-availability pair) and a degraded database whose reads run to the deadline, the second scrape waits about 5 seconds for the lock and then uses its own 5 seconds. With rendering on top, it passes the 10 second scrape_timeout the stuck-work page suggests. Prometheus then records up == 0 for that target exactly when the queue gauges matter most. With a healthy database, sampling takes milliseconds and nothing happens.
Possible fixes: let concurrent scrapes share one in-flight sample (the Adapter job host's sample cache does this), or start the deadline before taking the lock and accept that contention can cut a sample short.
2. Evidence and Adapter offline checks stop when metricsListener.networkExposure is an ${ENV} expression
Products that check configuration offline differ in how far they go when networkExposure is written as an environment expression:
- BReg, Casework, Scheduling, Messaging, Documents, Coordinator, Render, OID4VCI and OID4VP substitute a stand-in and keep checking the rest of the file.
- Evidence and Adapter cannot decode the value. They warn that it was not checked and stop checking the remainder of the file, so other configuration mistakes go unreported until start-up.
Nothing is refused that another product accepts. The gap is check depth. Giving Evidence and Adapter the same stand-in would align them with the other products.
- Vorherrschende Sprache
- Rust
- Sterne
- 2
- Forks
- 0
- Ø Merge
- 9 Std. 48 Min.
- Gemergte PRs (30 T.)
- 151
Entwicklungsumgebung
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus registrystack/registry-stack
-
area:breg enhancement
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 65/100
registrystack/registry-stack#2765 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 62/100
registrystack/registry-stack#2761 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 70/100
registrystack/registry-stack#2743 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 76/100
registrystack/registry-stack#2706 ·
Maintainer antworten meist innerhalb von 1 Tag
-
macOS contributor gates: Messaging config tests fail under the symlinked macOS temporary directoryOffen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 83/100
registrystack/registry-stack#2704 ·
Maintainer antworten meist innerhalb von 1 Tag
Alle Issues in registrystack/registry-stack
Ähnliche Issues
-
[Bug] 建议把黑白主题设置同步到启动页面Offenbug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 66/100
AstrBotDevs/AstrBot-desktop#197 ·
-
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 75/100
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 68/100
-
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 82/100
stackabletech/airflow-operator#898 ·
Maintainer antworten meist innerhalb von 1 Tag
-
2 advisory ignore entries no longer match anything (`bytes`, `time` already patched in `Cargo.lock`)Evtl. vergeben @zyl71 hat das heute übernommen. Offen
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 88/100