breg: keep `resultEffects` in the Action description for a profile that can read a Proposal but not start it
Maintainer antworten meist innerhalb von 1 Tag
Dieses Issue hat noch niemand übernommen.
Bewertung
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Anfängerfreundlichkeit
- 48/100
Rechercherichtung
Start with the Proposal metadata loop in crates/registry-breg/src/api/mod.rs:675-716 and the result effect filtering in crates/registry-breg/src/artifacts.rs:1331 and :1554-1566. Read the existing schema test at crates/registry-breg/src/tests/artifacts_response_schema_tests.rs:360-375, then add coverage for readable and hidden record types and confirm the reader still receives no routes. Done means reader-visible effects are filtered by record type, the existing populated-list test passes, and any changed schemas are regenerated.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
Problem
A profile with a Proposal get grant but no Start grant receives an Action description in GET /v1/metadata. The description hides the routes, which is deliberate: the profile cannot start the Action. It also sets resultEffects to an empty list. A client cannot then tell which record fields or record types the Action changes, so it has to guess, for example when it shows a reader what a Proposal would do once applied.
The blanking may have been deliberate. Neither the code nor the pull request that introduced it (#2040) says why. If it exists to avoid disclosing effects on record types the reader cannot see, the fix should keep that protection rather than blank everything.
Evidence
All line numbers are on origin/main at 36d25ef652.
crates/registry-breg/src/api/mod.rs:675to:716: the loop that adds a description for each visible Proposalgetgrant. It emptiesroutes(:706), removesrouteandconditionRoute, emptiesrequiredConditionKeys, then setsresultEffectsto[]at:716. The comment at:675states only the input-disclosure intent.crates/registry-breg/src/artifacts.rs:1331: the public Action entry buildsresultEffectsby filteringaction.effectsthroughselected_result_effects.crates/registry-breg/src/artifacts.rs:1554to:1566(action_selected_result_effects): with a selected profile, effects come only from that profile's Action permissionresults. A reader has no Action permission, so this path also yields an empty set. This is my reading of the code and I have not run it.- The set was introduced by commit 2ec3726883 (#2040, 2026-10-16).
git log -Sfinds no earlier version of the line, and the #2040 description does not mention it. crates/registry-breg/src/tests/artifacts_response_schema_tests.rs:360to:375asserts the populated list for a profile that holds an Action grant. No test asserts the empty list for a reader.- The clients decode the member as required:
crates/registry-breg-client/src/metadata.rs:3310, andresultEffectsincrates/registry-breg-client-node/client.d.ts:539.
Proposed change
- Stop blanking
resultEffectsfor a Proposal reader. Derive the list fromaction.result_effects(the effects a Proposal applies), not from an Action permission. - Keep record-type disclosure intact: list only effects whose
recordTypethe profile may see in the same metadata response. Decide whether an effect on a hidden record type is omitted or listed without detail, and record the decision. - Leave
routes,route,conditionRouteandrequiredConditionKeysas they are. - Document the field for readers on the Proposals configuration page.
Acceptance
- A test shows a Proposal reader sees the Action's effects for record types it can read.
- A test shows an effect on a record type the reader cannot read is not disclosed.
- A test shows the reader still gets no routes.
- The existing populated-list test still passes.
- The OpenAPI and metadata schema documents are regenerated with their generators if the change alters them.
- Vorherrschende Sprache
- Rust
- Sterne
- 2
- Forks
- 0
- Ø Merge
- 9 Std. 48 Min.
- Gemergte PRs (30 T.)
- 151
Entwicklungsumgebung
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus registrystack/registry-stack
-
area:breg enhancement
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 65/100
registrystack/registry-stack#2765 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 62/100
registrystack/registry-stack#2761 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 70/100
registrystack/registry-stack#2743 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 76/100
registrystack/registry-stack#2706 ·
Maintainer antworten meist innerhalb von 1 Tag
-
macOS contributor gates: Messaging config tests fail under the symlinked macOS temporary directoryOffen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 83/100
registrystack/registry-stack#2704 ·
Maintainer antworten meist innerhalb von 1 Tag
Alle Issues in registrystack/registry-stack
Ähnliche Issues
-
help wanted needs investigation priority: low
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 62/100
-
[Bug] 建议把黑白主题设置同步到启动页面Offenbug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 66/100
AstrBotDevs/AstrBot-desktop#197 ·
-
bug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
tomast1337/Puppeter-PptxGenJS#440 ·
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 72/100
n0-computer/iroh#4709 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 75/100
qingjian-team/qingjian#1114 ·
Maintainer antworten meist innerhalb von 2 Tagen