Fantom's shouldCollectCoverage answers true on every second call for the same benchmark: FANTOM_BENCHMARK_FILENAME_RE has the g flag
Maintainer antworten meist innerhalb von 2 Tagen
Bewertung
- Schwierigkeit
- 1/5
- Geschätzter Aufwand
- 1-3 Stunden
- Anfängerfreundlichkeit
- 20/100
- Issue-Typ
- Bug
- Klarheit
- Klar beschrieben
- Aktivitätsstatus
- Veraltet
- Tech-Stack
- javascript, react-native
Rechercherichtung
Read private/react-native-fantom/runner/coverageUtils.js, especially the regex declaration and shouldCollectCoverage, then inspect the related test area under private/react-native-fantom/runner/__tests__/. Start by running the supplied reproducer or the described Jest test; done means repeated calls return [false, false, false] for a benchmark and [true, true, true] for a non-benchmark. An open linked pull request (#60056) already addresses this issue.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
Description
private/react-native-fantom/runner/coverageUtils.js declares FANTOM_BENCHMARK_FILENAME_RE = /[Bb]enchmark-itest\./g (L16), and shouldCollectCoverage calls .test() on it (L23). With the g flag, .test() starts from the lastIndex of the previous match, so asked three times for the same benchmark path with collectCoverage: true, shouldCollectCoverage answers [false, true, false].
runner.js calls shouldCollectCoverage once per config, inside for (const testConfig of testConfigs) (L300, L387-L391), and passes the answer to the bundle's collectCoverage (L402), LLVM_PROFILE_FILE (L438) and the tester's enableCoverage (L444). So in a --coverage run, every other config of a benchmark with several configs runs with coverage. getFantomTestConfigs.js declares the same pattern without the flag (L75, https://github.com/react/react-native/pull/56423).
Steps to reproduce
- In a checkout of
main(61448351cc2) afteryarn install, putcoverageBenchmark-test.jsfrom the reproducer below inprivate/react-native-fantom/runner/__tests__/and runyarn jest private/react-native-fantom/runner/__tests__/coverageBenchmark-test.js; or runnode repro.cjs <path to the checkout>from the reproducer, which copies that test in, runs it, removes it, and exits 1 while the defect shows.
const globalConfig = {collectCoverage: true};
// The runner asks once per config of a test, always with the same path.
function askThreeTimes(testPath) {
return [1, 2, 3].map(() =>
shouldCollectCoverage(testPath, '', globalConfig),
);
}
Expected: askThreeTimes('View-benchmark-itest.js') is [false, false, false], and askThreeTimes('View-itest.js') stays [true, true, true].
Actual: askThreeTimes('View-benchmark-itest.js') is [false, true, false].
React Native Version
main at 61448351cc2 (nightly)
Affected Platforms
Build - Windows
Output of npx @react-native-community/cli info
Not applicable: this is Fantom's runner in React Native's own repository. The reproducer's run:
react-native 61448351cc2 (2026-11-16), Windows_NT 10.0.26300, node v26.12.1
Stacktrace or Logs
react-native 61448351cc2 (2026-11-16), Windows_NT 10.0.26300, node v26.12.1
private/react-native-fantom/runner/coverageUtils.js: const FANTOM_BENCHMARK_FILENAME_RE = /[Bb]enchmark-itest\./g;
copied coverageBenchmark-test.js to private/react-native-fantom/runner/__tests__/
$ yarn jest private/react-native-fantom/runner/__tests__/coverageBenchmark-test.js
removed private/react-native-fantom/runner/__tests__/coverageBenchmark-test.js
jest exited 1
failed: never collects coverage for a benchmark, however often it is asked
passed: collects coverage for a test that is not a benchmark
shouldCollectCoverage('View-benchmark-itest.js', '', {collectCoverage: true}), asked 3 times: [false, true, false]
shouldCollectCoverage('View-itest.js', '', {collectCoverage: true}), asked 3 times: [true, true, true]
SUMMARY: shouldCollectCoverage answers [false, true, false] for the same benchmark path asked 3 times with collectCoverage: true; expected [false, false, false]
MANDATORY Reproducer
https://gist.github.com/YevheniiKotyrlo/4bda8e7c8af665c0639274ee15918482 — node repro.cjs <path to a react-native checkout> exits 1 while a benchmark gets true on any of the three calls, and 0 once it gets false every time and the other test true every time.
Screenshots and Videos
No response
- Vorherrschende Sprache
- C++
- Sterne
- 127k
- Forks
- 25.5k
- Ø Merge
- 3 T. 22 Std.
- Gemergte PRs (30 T.)
- 235
Entwicklungsumgebung
- Kein Dockerfile und keine Docker-Compose-Datei
- Hat eine Pull-Request-Vorlage
- Beitragsleitfaden lesen
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus react/react-native
-
Needs: Author Feedback Needs: Repro
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 82/100
react/react-native#60059 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 2 Tagen
-
Needs: Triage :mag:
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 70/100
react/react-native#60000 ·
Maintainer antworten meist innerhalb von 2 Tagen
-
`yarn test-ios` exits before building RNTester: `objc-test.sh` launches the WebSocket server script #59433 deletedEvtl. vergeben @lazerg hat das vor 4 Tagen übernommen. Offen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 76/100
react/react-native#59939 ·
Maintainer antworten meist innerhalb von 2 Tagen
-
iOS Fabric pointer-handler reset leaves the next lone touch non-primaryEvtl. vergeben @alleneubank hat das vor 6 Tagen übernommen. Offen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 68/100
react/react-native#59919 ·
Maintainer antworten meist innerhalb von 2 Tagen
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 70/100
react/react-native#59722 ·
Maintainer antworten meist innerhalb von 2 Tagen
Alle Issues in react/react-native
Ähnliche Issues
-
bug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 76/100
petercorke/robotics-toolbox-python#943 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 1 Tag
-
area:build bug
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 90/100
NatronGitHub/openfx-arena#71 ·
Maintainer antworten meist innerhalb von 1 Tag
-
upstream-blocked
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 65/100
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 72/100
ROCm/FastFlowLM#1057 ·
Maintainer antworten meist innerhalb von 1 Tag
-
bug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 76/100
NatronGitHub/openfx-gmic#45 ·
Maintainer antworten meist innerhalb von 1 Tag