Patch API differences
Bewertung
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Anfängerfreundlichkeit
- 20/100
- Issue-Typ
- Feature
- Klarheit
- Größtenteils klar
- Aktivitätsstatus
- Veraltet
- Bereich
- backend
Rechercherichtung
The issue points to proposed API details in issue comment 825460643 and lists instance and function differences across the Basic, Lazy, NonEmpty, and LazyNonEmpty list modules. Start by reading that linked comment and comparing the modules against the listed gaps; the issue says the function review is still incomplete. Done means resolving which API differences should be addressed and completing the agreed changes; linked pull request #199 is already open.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
See https://github.com/purescript/purescript-lists/issues/183#issuecomment-825460643 for a proposed API
It looks like there are a few missing functions and instances across the different list modules in this library. To tackle this more systematically, I found the contents of each of the cells of a 4-way Venn diagram created by comparing the following modules:
- Basic (List)
- Lazy[List]
- NonEmpty[List]
- LazyNonEmpty[List]
I've only looked over the instances so far. These appear to be the gaps:
Lazymissing fromLazyNonEmptyListEq1,Ord1missing fromNonEmptyList,LazyNonEmptyListFoldable1,Traversable1missing fromLazyNonEmptyList
Here are some notes on the remaining differences, which appear to be fine:
- Missing from
*NonEmptyListMonoid - Needs empty Plus - Needs empty Alternative - Needs Plus MonadZero - Needs Alternative MonadPlus - Needs MonadZero Unfoldable - Only if you can produce an empty container Comonadis only in*NonEmptyList, since you can'textractsomething from an empty list.- Only non-basic lists need the
Newtypeconvenience wrapper.
I still need to look through the functions. Feel free to help me flag or dismiss any of those differences.
Here's a brief explanation of how to read an entry in the listing of cells. For example in this entry:
-----
LazyNonEmpty NonEmpty
-----
Comonad
It means that Comonad appears only in LazyNonEmpty and NonEmpty, but not in any other modules. More specifically, Comonad is the output of:
intersections [LazyNonEmpty, NonEmpty] `difference` unions [Basic, NonEmpty]
This diagram might help with visualizing the "cells":
Here's the full listing (empty cells omitted).
Instances:
-----
Lazy LazyNonEmpty Basic NonEmpty
-----
Alt
Applicative
Apply
Bind
Eq
Extend
Foldable
FoldableWithIndex
Functor
FunctorWithIndex
Monad
Ord
Semigroup
Show
Traversable
TraversableWithIndex
Unfoldable1
-----
Lazy LazyNonEmpty NonEmpty
-----
Newtype
-----
LazyNonEmpty NonEmpty
-----
Comonad
-----
NonEmpty
-----
Foldable1
Traversable1
-----
Lazy Basic
-----
Alternative
Eq1
MonadPlus
MonadZero
Monoid
Ord1
Plus
Unfoldable
-----
Lazy
-----
Lazy
Functions:
-----
Lazy LazyNonEmpty Basic NonEmpty
-----
concatMap
fromFoldable
head
init
last
length
singleton
tail
toUnfoldable
uncons
-----
Lazy Basic NonEmpty
-----
(!!), index
catMaybes
concat
drop
dropWhile
elemIndex
elemLastIndex
filter
filterM
findIndex
findLastIndex
foldM
group
groupBy
insertAt
intersect
intersectBy
mapMaybe
modifyAt
nub
nubBy
partition
reverse
snoc
span
take
takeWhile
union
unionBy
unzip
updateAt
zip
zipWith
zipWithA
-----
Basic NonEmpty
-----
group'
mapWithIndex
sort
sortBy
unsnoc
-----
LazyNonEmpty NonEmpty
-----
appendFoldable
fromList
toList
-----
NonEmpty
-----
cons
cons'
snoc'
-----
Lazy Basic
-----
(..), range
(\\), difference
Pattern(..)
alterAt
delete
deleteAt
deleteBy
insert
insertBy
many
null
slice
some
stripPrefix
transpose
-----
Basic
-----
dropEnd
manyRec
someRec
takeEnd
-----
Lazy LazyNonEmpty
-----
iterate
repeat
-----
Lazy
-----
cycle
foldrLazy
replicate
replicateM
scanrLazy
- Vorherrschende Sprache
- PureScript
- Sterne
- 61
- Forks
- 50
- Ø Merge
- 2 T. 6 Std.
- Gemergte PRs (30 T.)
- 1
Entwicklungsumgebung
- Kein Dockerfile und keine Docker-Compose-Datei
- Hat eine Pull-Request-Vorlage
- Kein Beitragsleitfaden
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus purescript/purescript-lists
-
ZipList is BindOffen
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 35/100
purescript/purescript-lists#219 · 1 Kommentar · 1 Reaktion ·
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 48/100
purescript/purescript-lists#218 ·
-
Data.List.NonEmpty.intersect and Data.List.NonEmpty.intersectBy throw when intersection emptyEvtl. vergeben @evaogbe hat das vor 1066 Tagen übernommen. Offengood first issue type: bug
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 1/100
purescript/purescript-lists#216 · 2 Kommentare ·
-
type: enhancement
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 25/100
purescript/purescript-lists#197 · 1 Kommentar ·
-
type: enhancement
Schwierigkeit 5/5 Über eine Woche Anfängerfreundlichkeit 24/100
purescript/purescript-lists#194 · 5 Kommentare ·
Alle Issues in purescript/purescript-lists
Ähnliche Issues
-
ManageSieve proxy: a backend's NO/BYE greeting is skipped as a capability line and reported as EOFOffenbug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 72/100
Maintainer antworten meist innerhalb von 1 Tag
-
Mend: dependency security vulnerability
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 62/100
ManageIQ/manageiq-pods#1476 ·
Maintainer antworten meist innerhalb von 1 Tag
-
mcp: typed tool handlers lose wrapped JSON-RPC errorsEvtl. wieder frei Ein Pull Request dazu wurde ohne Merge geschlossen. Offen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 85/100
modelcontextprotocol/go-sdk#1529 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 66/100
FinanceFlash/unvibecode#818 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 70/100