[Bug]: iOS navigation breaks after closing a full-screen video opened from a file link

Offen
  • Stimmt etwas nicht?
#33,998 2 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
48/100
Issue-Typ
Bug
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
ios, typescript
Bereich
mobile

Rechercherichtung

Start in apps/mobile/modules/t3-native-controls/ios/T3NativeVideoPresentation.swift, especially present and finish, and trace how the embedded player is attached to the source view’s UIViewController. Reproduce the linked MP4 flow on an iPhone and inspect navigation state after dismissing the player; the issue’s responder-chain explanation is unverified. Done means dismissing the video leaves the thread and navigation stack usable, including switching threads and going back.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

Before submitting
  • I searched existing issues and did not find a duplicate.
  • I included enough detail to reproduce or investigate the problem.
Area

apps/mobile

Steps to reproduce
  1. On an iPhone, open a thread whose assistant message links a local video file, for example Watch it: [clip.mp4](/path/to/clip.mp4).
  2. Tap the link. The video opens in the native full-screen player and plays.
  3. Close the player by swiping it down. It shrinks back into the thread.
  4. Go back to the thread list (swipe from the left edge or tap Back), then open any thread.
Expected behavior

Closing the video returns to the thread as it was. Back and opening other threads then work normally.

Actual behavior

From a screen recording of the steps above, about 18 s long:

  • Right after the player closes, the thread is scrolled to a different position, and within a second the app is back on the thread list.
  • The navigation stack no longer matches what is on screen. The list shows a Back button in its header. Tapping a thread row changes the header title to that thread, but the content stays the thread list, and rows can still be tapped through it.
  • Tapping Back then shows the original thread's content.
  • Going back once more turns the whole screen black, apart from the status bar. The app has to be force-quit.

It looks like navigation breaks as soon as the video closes: the native header and the visible screen stay out of sync from then on.

Impact

Major degradation or frequent failure

Version or commit

Current App Store iOS build on 2026-11-10 (exact build number not captured). The code below is from main at 047d4927.

Environment

iPhone (physical device), current iOS release. The video was an MP4 file on the host, linked from an assistant message.

Logs or stack traces

No crash log. The app doesn't terminate: it stays running with a broken screen until force-quit.

Screenshots, recordings, or supporting files

I have a screen recording. It isn't attached because it shows private thread content.

Workaround

Force-quit and reopen the app.

Additional context

Possible cause, from reading the code. I haven't verified this on a device.

When the tapped link's source view is on screen, T3NativeVideoPresentation.present takes the embedded path in T3NativeVideoPresentation.swift#L80-L95. It walks the source view's responder chain to the nearest UIViewController, which is the thread's react-native-screens RNSScreen. It then adds the AVPlayerViewController as a child of that screen controller, puts the player's view inside the link chip, and calls AVKit's private enterFullScreenAnimated:completionHandler:. On exit, finish() removes the child (L149-L156).

expo-video uses the same AVKit entry point, but it doesn't add the player controller as a child of the react-native-screens controller. Adding a child to an RNSScreen inside the native stack, and having AVKit present and dismiss full screen from it, may leave the stack's transition or view state inconsistent. That would fit the header and content disagreeing afterwards. The other path (presenter.present(controller, animated: true), used when there is no on-screen source) doesn't change the screen's child controllers.

Related, but not the same bug: #26662 and #32795 (Quick Look image previews failing to open), #26831 (inline videos no longer opening full screen).

Vorherrschende Sprache
TypeScript
Sterne
24.8k
Forks
6.4k
Ø Merge
10 Std. 56 Min.
Gemergte PRs (30 T.)
226

Entwicklungsumgebung

In Codespaces öffnen

Startet den Dev-Container des Projekts im Browser, mit Ihrem eigenen GitHub-Konto.

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus pingdotgg/t3code

Alle Issues in pingdotgg/t3code

Ähnliche Issues

Weitere Issues zu TypeScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.