0.6.6: lambdas that capture a throwing copy terminate under /Zc:lambda; audit the in-game tree

Offen
#247 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
46/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
cmake, cpp
Bereich
backend, testing-qa

Rechercherichtung

Start with clean/fsr/src/dllmain.cpp and compare its modelPlaces capture with DeviceRelease in clean/fsr/src/async_create.h; then audit the in-game tree listed in the issue for other throwing lambda captures. Read the contributor notes for the existing code rules and inspect TestDeviceHoldAllocationFailure in clean/fsr/tests/test_frontend.cpp. Done means all identified sites follow the proposed rule, the rule is documented, and the relevant throwing-copy test passes in the CI configuration.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

What

With MSVC's /Zc:lambda, a lambda whose capture copy throws terminates the process (std::terminate) instead of unwinding to the caller's handler. /Zc:lambda is on whenever /permissive- is, and the CMake targets of the front end build with /permissive-, so every release build of the in-game code has it on. A capture copy can throw whenever the captured object allocates when it is copied (std::string, std::vector, std::function holding a large callable): the throw is std::bad_alloc, so the case is out of memory, and the process ends in std::terminate instead of the error path.

It was found in the create worker's device hold (#225): [release, device] { release(device); } captured a std::function by copy. A test with a callable whose copy throws aborted with exit code 0xc0000409 in the CI configuration (cmake, Release, /permissive- /W4 /Zi) and not in a hand-made cl build without /permissive-. A stand-alone reproduction narrowed it to this switch: with /Zc:lambda alone the throw terminates, without it the exception reaches the catch; a plain copy of the same std::function (no lambda) is fine in every configuration.

Rule (proposed)

No lambda in code that runs in a game may capture, by copy or by init-capture, an object whose copy can throw. Use one of:

  • a named callable class whose constructor does the copy (that unwinds normally; #225 does this: DeviceRelease in clean/fsr/src/async_create.h), or
  • a capture whose copy cannot throw: a raw pointer, an index, a std::shared_ptr (copy is noexcept), or a std::move into an init-capture of a type with a noexcept move.

Known site

clean/fsr/src/dllmain.cpp: p.modelPlaces = [modelDir = config.modelDir] { ... } init-captures a std::string by copy at start-up. Out of memory at that point ends in std::terminate instead of the normal failure. It is the same class; it is not part of #225.

Asked for (0.6.6)

  1. Audit the whole in-game tree (front end, the D3D12 runtime and its interop, the Ray Reconstruction plugin and runtime, shared code that runs in the game process) for lambdas with a by-copy or init-capture of a type whose copy can throw; fix each as above.
  2. Write the rule in the contributor notes next to the other code rules.
  3. Optional: a small CI check (a grep for init-captures of std::string / std::vector / std::function in the in-game sources) so the rule holds.
  4. Keep a test that drives a throwing copy through any callable the fix touches (see TestDeviceHoldAllocationFailure in clean/fsr/tests/test_frontend.cpp): it must pass in the CI configuration.
Vorherrschende Sprache
C++
Sterne
12
Forks
2
Ø Merge
3 Std. 10 Min.
Gemergte PRs (30 T.)
171

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus phantoslayer21/wronggpu

Alle Issues in phantoslayer21/wronggpu

Ähnliche Issues

Weitere Issues zu C++

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.