[feat]: Update `<pf-v6-switch>` for PatternFly v6
Ein zugehöriger Pull Request wurde bereits gemerged.
- #3154 von @zeroedin — gemerged
Bewertung
Dieses Issue wurde noch nicht bewertet.
Beschreibung
Summary
Update `` to implement the PatternFly v6 Switch component.
Toggle switch for binary on/off choices with label support.
Prior Art
| Source | Element | Status |
|---|---|---|
| PFE v4 | `` | Exists |
| cem | `` | Exists |
| cockpit | `` | Exists |
| chickadee | `` | Exists |
Notes
- Implement as a Form-Associated Custom Element (FACE) using `ElementInternals`
- Use ARIA IDL attributes for cross-root ARIA (Baseline 2025)
Requirements
- MUST implement PFv6 visual designs
- MUST provide end-user feature parity with `@patternfly/react-core` Switch
- MUST participate in native form submission via FACE
- MAY adjust element API to leverage web platform strengths
- SHOULD maintain CSS custom property theming compatibility
- SHOULD expose useful CSS shadow parts
Element-specific considerations
- React `label`, `labelOff` - visible text beside toggle; `label` also used as `aria-label` fallback
- React `isChecked` (controlled) - reflect as `checked` attribute; default via `defaultChecked`
- React `isReversed` - places label before toggle; map to `reversed` attribute
- React `isDisabled` - `ElementInternals` should propagate disabled to form
- React `hasCheckIcon` - shows checkmark inside toggle when on; verify v6 still has this
- `name`/`value` attributes required for form submission
Checklist
Rename
- Delete `elements/pf-v5-switch/`
- Update `elements/package.json` exports
- Update `eslint.config.js` ignore globs if applicable
- Update docs `_snippets/` and `framework-integration/` references
Implementation
- API per `.claude/ADVICE.md`
- CSS uses v6 tokens, logical properties, nesting
- `@summary` and JSDoc on element class
- `formAssociated = true` and `ElementInternals` for form participation
- Form submission tested (`name`/`value` submitted when checked)
Demos
- Demos match patternfly.org naming/structure
- CSS custom properties match computed styles from patternfly.org (Chrome MCP)
- Visual parity verified via Chrome MCP
Tests
- Public API covered (attributes, properties, events, slots)
- `a11ySnapshot` assertions
- Form submission test
Reviews
- `/review-api` passes
- `/review-demos` passes
- `/review-a11y` passes
- `eslint` and `stylelint` pass
Ship
- Add changeset
- PR targets `staging/pfv6` (NOT `main`)
- Vorherrschende Sprache
- TypeScript
- Sterne
- 394
- Forks
- 107
- PR-Merge-Kennzahlen
- Keine gemergten PRs in 30 T.
Beitragsleitfaden
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus patternfly/patternfly-elements
-
bug
patternfly/patternfly-elements#3158 · 1 zugewiesene Person ·
-
patternfly/patternfly-elements#3136 · 1 Kommentar · 1 zugewiesene Person ·
-
docs
patternfly/patternfly-elements#3131 · 1 zugewiesene Person ·
-
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 55/100
patternfly/patternfly-elements#3122 ·
-
Schwierigkeit 5/5 Über eine Woche Anfängerfreundlichkeit 38/100
patternfly/patternfly-elements#3118 ·
Alle Issues in patternfly/patternfly-elements
Ähnliche Issues
-
VerificationGate: ATTRIBUTION quote guard never matches a normal quotation (\b around the quote) Offen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 75/100
danielmiessler/LifeOS#2234 ·
-
T: Bug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 75/100
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 65/100
-
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 85/100
-
Mend: dependency security vulnerability untriaged
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 70/100