tick: game steps read, clone and commit character rows through the store on the tick goroutine (about 12 ms a tick at 105 players)
Maintainer antworten meist innerhalb von 1 Tag
Dieses Issue hat noch niemand übernommen.
Bewertung
- Schwierigkeit
- 5/5
- Geschätzter Aufwand
- Über eine Woche
- Anfängerfreundlichkeit
- 18/100
- Issue-Typ
- Refactoring
- Klarheit
- Größtenteils klar
- Aktivitätsstatus
- Aktiv
- Tech-Stack
- go
- Bereich
- backend, performance
Rechercherichtung
Start from Ticker.runScheduledTick and Ticker.runDivision to see which game steps call store.ReadState through enterworld.Deps.Read and Deps.runCharacterUpdate, then follow the commit path (commitCheckedLocked, commitTxLocked, upsertTimedTx). Done means one shared read per character per tick, deferred updates where possible, a 100-player benchmark, and a live capture under 3 ms per tick. This needs store and tick-loop knowledge, so it is not a first task.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
Live capture 2026-11-10 20:03Z on release 1dd0e9948 with 105 sessions attached (sro-tickbudget capture, loopback profiler): 954 ticks, 61.1 ms per tick (phase:total, exact from tick_zones), against the 10 ms target of #2150. CPU numbers below are the 30 s profile over the 301 ticks its bracketing snapshots count, stacks through Ticker.runScheduledTick or Ticker.runDivision only. At 18:00Z with 29 players the same server showed p99 60 ms; at 105 players p50 is 60 ms and p99 120 ms: these costs grow with players.
What costs
The action hook is 19.9 ms of the tick, and most of its CPU is the store, reached from game steps on the tick goroutine:
| Work on the tick goroutine | ms per tick |
|---|---|
store.ReadState (through enterworld.Deps.Read) |
7.1 |
character updates (Deps.runCharacterUpdate) |
5.1 |
commits inside those updates (commitCheckedLocked, commitTxLocked; upsertTimedTx 3.9) |
5.3 |
character clones (Character.snapshotWith, cloneCharacterFiltered) |
3.3 |
Who reads (share of the 7.1 ms): characterSnapshotCast 28%, companionPresentations 14%, questMarkerTick 11%, PopulationPlayers 9%, WorldSnapshotInto 8%, characterSnapshotCombatAdmitted 6%, monsterRewardRoster 5%, then a long tail. Who writes: Deps.Update is 70% of the update time (immediate), UpdateDeferred 18%, UpdateManyDeferred 8%.
The same character is read and cloned several times inside one tick by different steps, and an immediate Update pays a commit inside the tick. #2032 (ReadState 8% of tick CPU) and #2141 closed, and the cost is back at this load. The async writer of #2944 (SRO_STORE_ASYNC_COMMIT) is merged and off on the live shard.
Done when
- One read per character per tick: the steps of one tick share a snapshot instead of each calling
ReadState; a write in the tick invalidates it. The invariant is written where the cache lives. - Tick steps use the deferred update path unless a step proves it needs the row committed before the next step; each remaining immediate
Updateon the tick path is listed with its reason. - A benchmark at 100 synthetic players pins the store's share of the action hook, and the allocation budget test covers the clones.
- A live capture after release shows
ReadStateplus character updates under 3 ms per tick at about 100 players. - Separate owner decision, not part of the code: whether the live shard turns
SRO_STORE_ASYNC_COMMITon. Record the live numbers that argue for or against it here.
Part of #2150.
- Vorherrschende Sprache
- Go
- Sterne
- 97
- Forks
- 61
- Ø Merge
- 4 Std. 14 Min.
- Gemergte PRs (30 T.)
- 913
Entwicklungsumgebung
- Kein Dockerfile und keine Docker-Compose-Datei
- Hat eine Pull-Request-Vorlage
- Beitragsleitfaden lesen
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus opensro-dev/opensro
-
area: client enhancement priority: low
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 75/100
opensro-dev/opensro#3681 ·
Maintainer antworten meist innerhalb von 1 Tag
-
area: client bug priority: low
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
opensro-dev/opensro#3228 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 1 Tag
-
Format one minified client file with dprint (ongoing: one file per PR)Evtl. vergeben Ein verknüpfter Pull Request ist offen oder bereits gemergt. Offenarea: client enhancement good first issue priority: low
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 75/100
opensro-dev/opensro#1 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 1 Tag
-
area: server bug priority: medium
Schwierigkeit 3/5 Ein halber Tag Anfängerfreundlichkeit 55/100
opensro-dev/opensro#3687 ·
Maintainer antworten meist innerhalb von 1 Tag
-
area: ops bug priority: high
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 32/100
opensro-dev/opensro#3685 ·
Maintainer antworten meist innerhalb von 1 Tag
Alle Issues in opensro-dev/opensro
Ähnliche Issues
-
area/networking kind/bug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 69/100
siderolabs/talos#14972 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 72/100
Maintainer antworten meist innerhalb von 1 Tag
-
kubectl wait outputs cryptic "error: unrecognized condition: []" when --for is omittedEvtl. vergeben @muskan-creates352 hat das heute übernommen. Offenkind/bug needs-triage
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 84/100
kubernetes/kubectl#1910 · 1 Kommentar ·
-
needs-triage
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 66/100
stacklok/toolhive-catalog#1967 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 66/100
unbound-force/gaze#353 ·
Maintainer antworten meist innerhalb von 1 Tag