Hacktoberfest 2026: die Issues, die Maintainer für den Oktober markiert haben – offen und einsteigerfreundlich. Hacktoberfest-Issues durchsuchen

A sheet is printed at its own width: nothing fits it to paper, and we add a ruler it has no room for

Offen
  • Stimmt etwas nicht?
#816 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
5/5
Geschätzter Aufwand
Über eine Woche
Anfängerfreundlichkeit
25/100
Issue-Typ
Feature
Klarheit
Muss geklärt werden
Aktivitätsstatus
Ruhig
Tech-Stack
cpp, html
Bereich
desktop

Rechercherichtung

Start with html/document_style.cpp and html/document_element.cpp to understand sheet widths and the ruler, then read html/document.cpp and document_element.hpp for page-layout handling. The issue leaves a design decision between fitting and pagination, and notes that ODS page styles are not parsed; agree on scope before making changes. Done means printed sheets fit or paginate as intended without changing the on-screen view.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

A user reports that a one-page .ods opens and displays correctly, but printed from an Android phone it comes out too wide and is cut off along the right edge; the same file prints correctly from a PC. The frontend half of that report is opendocument-app/OpenDocument.droid#644, which concludes the more correct fix belongs here — this is that half.

What the renderer does today

A sheet is laid out at the width the file states, and at nothing else. translate_sheet writes one <col> per column carrying the document's column width as both width and min-width (html/document_style.cpp:312), and .odr-sheet is table-layout:fixed. The table is therefore exactly as wide as the file says, in the file's own centimetres or inches, whatever it is rendered onto.

Nothing then relates that to paper.

  • fragment_content_pixels(const Sheet &, const HtmlConfig &) returns nothing — "A sheet reflows; there is no page box to fit" (html/document.cpp:58). Only a text root, a slide and a drawing page get a fitted width.
  • Sheet has no page_layout() (document_element.hpp:309): the sheet's page style — paper size, orientation, scale / fit-to-pages, print ranges, repeated rows and columns — is neither parsed nor exposed, so even a renderer that wanted to honour it has nothing to read.
  • The one @media print block the output carries pins the zoom back to actual size (html/common.cpp:249), correctly — "paper has its own geometry" — but nothing fits the sheet to that geometry afterwards. No @page rule is written anywhere, and HtmlConfig has no print-related setting.

And we add width the file does not have. The ruler — the corner/row-number gutter plus the <thead> of column letters (html/document_element.cpp:201-256) — measures 38px, 0.40in ≈ 1.0cm, at the default ruler font, and prints along with everything else. A spreadsheet application prints neither by default. A sheet whose own columns exactly fill A4's text width is therefore about a centimetre too wide as html before any other factor.

Measured

Chrome headless --print-to-pdf on the output of test/data/input/odr-public/ods/file_example_ODS_10.ods (8 columns × 0.889in, table 7.50in including the 0.40in ruler). That path has no print-preview scale control, like the print adapter a WebView hands the Android print framework.

table width paper result
7.50in A4, 20mm margins (content 6.69in) fits — the browser shrinks it
11.6in (columns widened to 1.4in) Letter, default margins (content ≈7.7in) fits, at a shrink that leaves the text barely legible
13.2in (columns 1.6in) Letter, default margins cut off: column H is sliced mid-column, its values are absent from the pdf entirely, and the lost columns continue on no further page — one page out

So what saves the output today is a browser shrink-to-fit heuristic we neither ask for nor control: bounded (it gave up somewhere between 1.5× and 1.7× of the printable width here), silent when it gives up, and different per browser and per print path. Desktop print dialogs expose a scale/fit control and a preview on top of it; the Android print framework offers the user no scaling at all (PrintingManager hands webView.createPrintDocumentAdapter() a default PrintAttributes). That is the reported asymmetry between the phone and the PC.

What a fix has to decide

  • Fit, or paginate. Scaling the sheet to the page width is the small fix and matches what the browser is already half-doing, but a wide sheet then prints unreadably small. A spreadsheet application paginates instead, and paginating column-wise means either emitting the sheet in slices or a @page plus a transform per slice — html cannot break a table horizontally on its own.
  • What the file already says. Paper size, orientation, fit-to-pages, print ranges and repeated header rows/columns all live in the ods page style and are the answer to both of the above. None of it is parsed. Doing this properly starts there, and it is also what odt headers/footers (#307) and #174 would want.
  • The ruler should not print — a spreadsheet application does not print it, and it is the centimetre a page that has none to spare is losing. The cheapest partial improvement, and independent of the rest.
  • Whatever lands must not change the on-screen view, which is what the ruler and the natural width are there for.
Vorherrschende Sprache
C++
Sterne
41
Forks
10
Ø Merge
12 Std. 4 Min.
Gemergte PRs (30 T.)
297

Entwicklungsumgebung

Dieses Projekt bietet weder Dev-Container noch Dockerfile noch Beitragsleitfaden – die Einrichtung liegt bei Ihnen. Beginnen Sie mit der README; die allgemeinen Schritte stehen in unserem Leitfaden für den ersten Beitrag.

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus opendocument-app/OpenDocument.core

Alle Issues in opendocument-app/OpenDocument.core

Ähnliche Issues

Weitere Issues zu C++

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.