[Workload]: disk-snapshot
Dieses Issue hat noch niemand übernommen.
Bewertung
- Schwierigkeit
- 5/5
- Geschätzter Aufwand
- Über eine Woche
- Anfängerfreundlichkeit
- 35/100
- Issue-Typ
- Feature
- Klarheit
- Größtenteils klar
- Aktivitätsstatus
- Ruhig
- Tech-Stack
- bash, go, kubernetes
- Bereich
- devops, infrastructure, testing-qa
Rechercherichtung
Beginne damit, die vorhandene disk-Workload und ihren Einstiegspunkt für die Generierung zu finden, und verfolge anschließend, wie ihr DataVolume, Secret und systemd-Dienst definiert sind. Verwende virtwork-snapshot-sidecar.sh, virtwork-disk-snapshot.service und das Snapshot-Template als Verhaltensreferenzen, während du das RBAC- und Verifizierungsdesign klärst. Die Aufgabe ist erledigt, wenn eine auswählbare disk-snapshot-Workload während der fio-I/O Snapshots erstellt, die Aufbewahrung anwendet und das konfigurierte Snapshot-Verhalten dokumentiert oder validiert.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
Workload Name
disk-snapshot
Workload Description
A variant of the existing disk workload that runs fio against a data disk while a sidecar script periodically triggers CSI VolumeSnapshots, validating I/O consistency and data integrity during snapshot operations. Produces the same sustained mixed I/O signals as the disk workload (IOPS, throughput, latency) plus snapshot-specific signals: snapshot creation latency, snapshot size, and — critically — whether the snapshot captures a crash-consistent or application-consistent state while I/O is actively in flight.
This is the scenario every storage partner dreads and every storage partner must prove works: "What happens when you snapshot a disk that is actively being written to?" The existing disk workload generates fio I/O, and a partner can manually trigger snapshots during a run, but there's no automated, reproducible way to validate snapshot-under-load behavior. This workload makes that test continuous and auditable.
The sidecar script runs inside the VM (not as a Kubernetes controller) and uses kubectl or virtctl to create VolumeSnapshot CRs against the VM's data disk PVC at configurable intervals. After each snapshot, it optionally verifies the snapshot by restoring it to a temporary PVC and running a filesystem check.
Tooling and Packages
I/O workload (identical to existing disk workload):
- Tool:
fiowith mixed random/sequential profiles - RPM packages:
fio - systemd service:
virtwork-disk.service(reused from existingdiskworkload)
Snapshot trigger sidecar:
- Tool:
kubectl(oroc) CLI inside the VM, authenticated via a projected ServiceAccount token - RPM packages:
kubernetes-clientor direct binary download ofkubectl - systemd service:
virtwork-disk-snapshot.service - Command loop:
while true; do kubectl create -f /etc/virtwork/snapshot-template.yaml sleep $SNAPSHOT_INTERVAL done - Configurable parameters:
snapshot-interval: seconds between snapshot triggers (default: 300 — every 5 minutes)snapshot-class: VolumeSnapshotClass name (required — depends on storage backend)snapshot-retain: number of snapshots to retain before deleting oldest (default: 5)snapshot-verify: whether to restore and fsck each snapshot (default: false — expensive)
VM Count Model
Single VM (like cpu, memory, disk)
Required Resources
- Persistent storage (DataVolume)
- Kubernetes Service (for inter-VM communication)
- Kubernetes Secret (for credentials or config)
- Additional CPU/memory beyond defaults
- GPU or special device passthrough
The DataVolume is the same as the existing disk workload — a CDI-provisioned persistent disk for fio. The Secret holds a ServiceAccount token (or kubeconfig) that grants the VM's snapshot sidecar permission to create VolumeSnapshot CRs. Additional RBAC is needed: a ServiceAccount with create/delete/list on volumesnapshots.snapshot.storage.k8s.io in the workload namespace.
Cloud-Init Details
packages:
- fio
write_files:
- path: /etc/virtwork/snapshot-template.yaml
content: |
apiVersion: snapshot.storage.k8s.io/v1
kind: VolumeSnapshot
metadata:
generateName: virtwork-disk-snap-
namespace: <namespace>
labels:
app.kubernetes.io/managed-by: virtwork
virtwork/component: disk-snapshot
spec:
volumeSnapshotClassName: <snapshot-class>
source:
persistentVolumeClaimName: <pvc-name>
- path: /usr/local/bin/virtwork-snapshot-sidecar.sh
permissions: '0755'
content: |
#!/bin/bash
set -euo pipefail
INTERVAL="${SNAPSHOT_INTERVAL:-300}"
RETAIN="${SNAPSHOT_RETAIN:-5}"
NAMESPACE="${SNAPSHOT_NAMESPACE:-<namespace>}"
KUBECONFIG="${KUBECONFIG:-/etc/virtwork/kubeconfig}"
export KUBECONFIG
while true; do
TIMESTAMP=$(date +%s)
echo "=== Creating snapshot at $(date -Iseconds) ==="
# Create snapshot
kubectl apply -f /etc/virtwork/snapshot-template.yaml
# Wait for snapshot to be ready
SNAP_NAME=$(kubectl get volumesnapshot -n "$NAMESPACE" \
-l virtwork/component=disk-snapshot \
--sort-by=.metadata.creationTimestamp \
-o jsonpath='{.items[-1].metadata.name}')
kubectl wait volumesnapshot/"$SNAP_NAME" -n "$NAMESPACE" \
--for=jsonpath='{.status.readyToUse}'=true \
--timeout=120s 2>/dev/null && \
echo "Snapshot $SNAP_NAME ready" || \
echo "WARNING: Snapshot $SNAP_NAME not ready within timeout"
# Prune old snapshots beyond retention limit
SNAP_COUNT=$(kubectl get volumesnapshot -n "$NAMESPACE" \
-l virtwork/component=disk-snapshot \
--no-headers 2>/dev/null | wc -l)
if [ "$SNAP_COUNT" -gt "$RETAIN" ]; then
DELETE_COUNT=$((SNAP_COUNT - RETAIN))
kubectl get volumesnapshot -n "$NAMESPACE" \
-l virtwork/component=disk-snapshot \
--sort-by=.metadata.creationTimestamp \
-o jsonpath='{range .items[*]}{.metadata.name}{"\n"}{end}' | \
head -n "$DELETE_COUNT" | \
xargs -I{} kubectl delete volumesnapshot/{} -n "$NAMESPACE"
echo "Pruned $DELETE_COUNT old snapshots"
fi
sleep "$INTERVAL"
done
- path: /etc/systemd/system/virtwork-disk-snapshot.service
content: |
[Unit]
Description=Virtwork disk snapshot trigger sidecar
After=network-online.target virtwork-disk.service
Wants=virtwork-disk.service
[Service]
Type=simple
Environment=SNAPSHOT_INTERVAL=300
Environment=SNAPSHOT_RETAIN=5
Environment=SNAPSHOT_NAMESPACE=<namespace>
ExecStart=/usr/local/bin/virtwork-snapshot-sidecar.sh
Restart=always
RestartSec=30
[Install]
WantedBy=multi-user.target
runcmd:
- curl -Lo /usr/local/bin/kubectl "https://dl.k8s.io/release/$(curl -sL https://dl.k8s.io/release/stable.txt)/bin/linux/amd64/kubectl"
- chmod +x /usr/local/bin/kubectl
- systemctl enable --now virtwork-disk.service
- systemctl enable --now virtwork-disk-snapshot.service
Use Case
- Storage partners (CSI driver vendors — NetApp, Pure Storage, Dell, HPE, Red Hat ODF): The primary audience. Every CSI driver must handle VolumeSnapshot correctly while I/O is in flight. The critical questions: Does the snapshot complete without errors? Does it capture a consistent state? Does fio I/O latency spike during the snapshot? Does the snapshot size grow linearly with data written? This workload answers all four continuously and automatically.
- Backup/DR partners (Velero, Trilio, Kasten): These products use CSI VolumeSnapshots as the backup primitive. They need to validate that snapshot-based backups taken during active I/O are restorable and consistent. The
--snapshot-verifyoption (restore + fsck) provides the restore validation that backup products depend on. - Data protection / CDP partners (Zerto, Portworx): Continuous data protection products need to understand snapshot overhead and I/O impact at various snapshot frequencies. Tuning
snapshot-intervalfrom 300s down to 30s stresses the CDP pipeline and reveals performance cliffs. - OpenShift platform validation: Validates that the CSI snapshot controller, external-snapshotter, and the storage backend work correctly together under sustained I/O from a KubeVirt VM — a less commonly tested path than pod-based snapshots.
Additional Context
- Relationship to existing
diskworkload: This workload is a superset ofdisk. The fio configuration is identical — the same systemd service, same I/O profiles, same data disk setup. The snapshot sidecar is an additional systemd service that runs alongside fio. Implementation options:- New workload type (
disk-snapshot): cleaner separation, explicit opt-in. - Flag on existing
diskworkload (--enable-snapshots): less code duplication, but muddies the single-responsibility of thediskworkload.
Option 1 is recommended — it follows the existing pattern where each workload type is a distinct, self-contained unit.
- New workload type (
- RBAC requirements: The snapshot sidecar needs a ServiceAccount with permissions to manage VolumeSnapshot CRs. This is additional RBAC beyond what virtwork currently creates. The implementation should:
- Create a ServiceAccount in the workload namespace
- Create a Role with
create/delete/get/listonvolumesnapshotsandvolumesnapshotcontents - Create a RoleBinding
- Project the ServiceAccount token into the VM (or generate a kubeconfig Secret)
- VolumeSnapshotClass is required: Unlike other workloads that work with any storage class, this workload requires a VolumeSnapshotClass to be configured on the cluster. The implementation should fail fast with a clear error if
snapshot-classis not specified or doesn't exist. - Snapshot verification (optional): The
--snapshot-verifymode restores each snapshot to a temporary PVC, mounts it (or attaches to a temporary pod), runsfsck, and deletes the temporary PVC. This is expensive (creates an extra PVC per snapshot cycle) but provides the strongest consistency guarantee. Default to off; document as available for thorough validation. - I/O impact measurement: The most valuable metric is fio's latency during the snapshot window vs outside it. fio's
--output-format=jsoncaptures per-second latency data. Partners can correlate latency spikes with snapshot creation timestamps to quantify snapshot overhead. - Composability: This workload pairs with
chaos-disk(snapshot during disk-full conditions) andchaos-network(snapshot when storage network is degraded) for comprehensive storage resilience testing.
- Vorherrschende Sprache
- Go
- Sterne
- 0
- Forks
- 0
- PR-Merge-Kennzahlen
- Keine gemergten PRs in 30 T.
Entwicklungsumgebung
- Enthält ein Dockerfile oder eine Docker-Compose-Datei
- Keine Pull-Request-Vorlage
- Kein Beitragsleitfaden
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus opdev/virtwork
-
good first issue needs-triage size/L workload-request workload/variant
Schwierigkeit 5/5 Über eine Woche Anfängerfreundlichkeit 45/100
-
needs-triage priority/awaiting-more-evidence size/XL workload-request workload/tier-2
Schwierigkeit 5/5 Über eine Woche Anfängerfreundlichkeit 48/100
-
[Workload]: encryptionOffenneeds-triage size/L workload-request workload/tier-3
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 48/100
-
[Workload]: windowsOffenneeds-triage size/XXL workload-request workload/tier-3
Schwierigkeit 5/5 Über eine Woche Anfängerfreundlichkeit 35/100
-
[Workload]: gpu-computeOffenneeds-triage size/XL workload-request workload/tier-3
Schwierigkeit 5/5 Über eine Woche Anfängerfreundlichkeit 38/100
Ähnliche Issues
-
bug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
Maintainer antworten meist innerhalb von 2 Tagen
-
bug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 83/100
devlikeapro/waha#2322 ·
Maintainer antworten meist innerhalb von 2 Tagen
-
validateDeclaredPath lets control characters through into the Gradle init script's Groovy literalOffenagent-butler-finding agent-research bug ready-for-agent
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
jordansmall/spindrift#5821 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 75/100
Maintainer antworten meist innerhalb von 1 Tag
-
[rmqctl][Bug] Windows build script fails when the output directory is absentEvtl. vergeben Ein verknüpfter Pull Request ist offen oder bereits gemergt. Offen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 72/100
apache/rocketmq-dashboard#7243 ·
Maintainer antworten meist innerhalb von 3 Tagen