Deliver up-to-date CA certificates to ExApps without rebuilding their images
Maintainer antworten meist innerhalb von 3 Tagen
Dieses Issue hat noch niemand übernommen.
Bewertung
- Schwierigkeit
- 5/5
- Geschätzter Aufwand
- Über eine Woche
- Anfängerfreundlichkeit
- 30/100
- Issue-Typ
- Feature
- Klarheit
- Muss geklärt werden
- Aktivitätsstatus
- Aktiv
- Tech-Stack
- docker, kubernetes, php
- Bereich
- backend-api-design, infrastructure, security
Rechercherichtung
Beginne damit, die bestehende CA-Auslieferung rund um ICertificateManager::getAbsoluteBundlePath() und den Einstiegspunkt /k8s/exapp/install_certificates nachzuverfolgen, und vergleiche anschließend das Verhalten von Docker, Kubernetes und dem manuellen Daemon. Überprüfe den Ablauf von /heartbeat und /init, den NPA_NC_CERT-Vertrag von nc_py_api und die Diagnosen von Test Deploy. Als erledigt gilt eine festgelegte backendübergreifende Lösung, die Aktualisierung, gehärtete Umgebungen, Client-Kompatibilität und die Aufteilung der Arbeit mit HaRP abdeckt.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
Problem
An ExApp trusts whatever CA certificates were baked into its image on the day the image was built. Public CAs keep introducing new roots, and admins use private PKIs, so over time an ExApp image starts rejecting perfectly valid certificates of the Nextcloud instance it has to call back.
The typical symptom: the ExApp container starts, AppAPI reaches it (/heartbeat and /init answer 200), but the ExApp's own request to Nextcloud fails with CERTIFICATE_VERIFY_FAILED (unable to get local issuer certificate or self-signed certificate in certificate chain). The deploy then hangs at the init step. For the admin this is hard to read, because the instance certificate is valid in every browser.
"Test Deploy" is hit first, since it is the first thing an admin runs, and its image is only rebuilt manually. Rebuilding the image fixes it for a while (nextcloud/test-deploy#44), but that does not scale: every ExApp image has the same problem, and we cannot rebuild and re-release all of them each time a CA ships a new root.
What happens today
- Docker and HaRP (Docker) daemons: at deploy time AppAPI reads the Nextcloud CA bundle (
ICertificateManager::getAbsoluteBundlePath(), i.e. the bundle shipped with the server plus everything imported withocc security:certificates:import), copies the certificates into the container and runsupdate-ca-certificates/update-ca-trustthere (introduced for #411). This works, with limits:- it runs only on deploy and update, so certificates imported later do not reach ExApps that are already running;
- it needs a supported OS, the update tool in the image, a writable root filesystem and root inside the container;
- it only helps clients that read the OS trust store. Clients with their own bundle (certifi based ones, Node.js, Java) ignore it.
- Kubernetes daemon: AppAPI sends the same bundle to HaRP, but
/k8s/exapp/install_certificatesis a no-op and nothing is mounted into the ExApp pod. An ExApp on Kubernetes only ever has the CA store of its image, so neither newer public roots nor a private CA can be delivered at all. Exec-based installation would not be a good fit there anyway (read-only root filesystems, non-root policies). - Manual daemons: nothing is delivered, which is fine, the developer owns that environment.
Goal
Collect ideas for a way to hand ExApps an up-to-date set of trusted CAs from the Nextcloud side, so that:
- a valid instance certificate works without rebuilding any ExApp image,
- certificates imported into Nextcloud reach ExApps on all deploy backends, including Kubernetes,
- it works in hardened environments (non-root, read-only root filesystem, no exec into the container).
Ideas to evaluate
- Mount a bundle instead of installing into the image. Deliver the Nextcloud CA bundle as a read-only file: a ConfigMap or Secret created by HaRP on Kubernetes, a bind mount or
docker cpof a single file on Docker. No exec, no package tooling, works with a read-only root filesystem. On Kubernetes this needsconfigmaps(orsecrets) permissions for the HaRP service account. - A documented contract for where the bundle is. Set the conventional environment variables on every ExApp (
SSL_CERT_FILE,REQUESTS_CA_BUNDLE,CURL_CA_BUNDLE,NODE_EXTRA_CA_CERTS) and possibly an AppAPI specific one, so SDKs can pick it up explicitly. nc_py_api already hasNPA_NC_CERTfor this, other languages would get the same rule in the ExApp development docs. - Refresh without redeploy. Re-deliver the bundle when it changes (certificate imported or removed, server update brings a newer bundle), for example on ExApp enable, through a background job, or with an occ command. With a mounted ConfigMap the update can propagate without touching the pod.
- Let the admin reference an existing trust source. A daemon option that points to a ConfigMap or Secret already managed in the cluster (e.g. by trust-manager), for environments that manage trust centrally.
- Keep images fresh anyway. Scheduled rebuilds of test-deploy (and a recommendation for ExApp authors) so base image updates are picked up. This only mitigates the public root case and does nothing for private CAs, so it complements the points above rather than replaces them.
- Better diagnostics. When init fails because of TLS verification, surface that reason in the Test Deploy dialog and in the ExApp status instead of a generic init timeout, and make the Test Deploy log message point to certificates rather than suggesting plain HTTP.
Open questions
- Should the delivered bundle replace the image's CA store or be added to it?
- One mechanism for all backends (file mount plus environment variables), or keep the in-container installation on Docker and add the mount only for Kubernetes?
- How do ExApps whose HTTP client ignores both the OS store and the environment variables opt in?
- Where does the work split between app_api and HaRP, and does it need a new HaRP API version?
- Vorherrschende Sprache
- PHP
- Sterne
- 199
- Forks
- 26
- Ø Merge
- 2 T. 6 Std.
- Gemergte PRs (30 T.)
- 48
Entwicklungsumgebung
- Kein Dockerfile und keine Docker-Compose-Datei
- Keine Pull-Request-Vorlage
- Beitragsleitfaden lesen
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus nextcloud/app_api
-
Daemon delete dialog: "Remove all ExApps" checkbox and `removeExApps` parameter have no effectOffen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 85/100
Maintainer antworten meist innerhalb von 3 Tagen
-
Schwierigkeit 5/5 Über eine Woche Anfängerfreundlichkeit 35/100
nextcloud/app_api#1099 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 3 Tagen
-
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 65/100
nextcloud/app_api#1021 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 3 Tagen
-
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 38/100
nextcloud/app_api#1013 · 2 Kommentare ·
Maintainer antworten meist innerhalb von 3 Tagen
-
daemon enhancement
Schwierigkeit 3/5 1-2 Tage Anfängerfreundlichkeit 52/100
Maintainer antworten meist innerhalb von 3 Tagen
Alle Issues in nextcloud/app_api
Ähnliche Issues
-
sync-en
Schwierigkeit 1/5 1-3 Stunden Anfängerfreundlichkeit 68/100
Maintainer antworten meist innerhalb von 4 Tagen
-
Перевод устарел
Schwierigkeit 2/5 Ein halber Tag Anfängerfreundlichkeit 62/100
-
feature request
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 88/100
Maintainer antworten meist innerhalb von 1 Tag
-
home php
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 62/100
vincent-peugnet/wcms#670 ·
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 62/100
freescout-help-desk/freescout#5731 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 1 Tag