Elicitation results are not checked against `requested_schema`, but the docs say they match it

Offen
  • Stimmt etwas nicht?
#661 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

@atesgoral arbeitet bereits daran.

Seit 06.11.2026.

  • #669 von @atesgoral — offen

Bewertung

Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
35/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Veraltet
Tech-Stack
ruby
Bereich
backend-api-design, security

Rechercherichtung

Start with lib/mcp/server_session.rb at create_form_elicitation, create_url_elicitation, and fulfill_input_request, then read docs/_server/elicitation.md for the documented contract. Check how the SDK represents validation errors and test these methods with the supplied invalid action and schema values. Done means invalid actions and invalid accepted content are rejected, with tests covering the stated cases.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

bug

docs/_server/elicitation.md says: "Per the MCP specification, the client validates the user's input against this schema before returning it, so the content of an accept response matches the requested shape." The server does not check this.

ServerSession#create_form_elicitation (server_session.rb:209-224), #create_url_elicitation (:231-246) and #fulfill_input_request (:253-255, used by the legacy input_required shim) return the client's result as received. action is not limited to accept, decline and cancel, and content is not checked against requested_schema (types, required, enum). A buggy or non-compliant client can return wrong types or values outside an enum, and handlers that follow the docs use them as-is.

Repro

Run from the repository root with bundle exec ruby -I lib repro.rb. The stub transport plays the client's reply.

require "mcp"

class ClientReply
  def initialize(reply)
    @reply = reply
  end

  def send_request(_method, _params = nil, **)
    @reply
  end

  def send_notification(*, **)
    true
  end
end

reply = { action: "accept", content: { replicas: "lots", environment: "unlisted" } }
server = MCP::Server.new(name: "example")
session = MCP::ServerSession.new(server: server, transport: ClientReply.new(reply), session_id: "A")
session.store_client_info(client: { name: "client", version: "1" }, capabilities: { elicitation: {} })

result = session.create_form_elicitation(
  message: "Deploy settings",
  requested_schema: {
    type: "object",
    properties: {
      replicas: { type: "integer" },
      environment: { type: "string", enum: ["staging", "production"] },
    },
    required: ["replicas", "environment"],
  },
  related_request_id: 1,
)

p result

Expected: an error (or at least not an accept result), because replicas is not an integer and environment is not in the enum.

Actual: {action: "accept", content: {replicas: "lots", environment: "unlisted"}}

The same happens with an unknown action such as {action: "approve-everything"}.

Suggested fix

Check action and, for accept, check content against the flat requested_schema before returning it from these methods, and raise a validation error on a mismatch. The elicitation schema subset is small (flat object, primitive types, enum, required). If validation is out of scope, change the docs to say that handlers must validate content themselves.

Vorherrschende Sprache
Ruby
Sterne
940
Forks
143
Ø Merge
1 T. 3 Std.
Gemergte PRs (30 T.)
47

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus modelcontextprotocol/ruby-sdk

Alle Issues in modelcontextprotocol/ruby-sdk

Ähnliche Issues

Weitere Issues zu Ruby

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.