Typing of ScheduleItem incomplete

Offen
#428 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
2/5
Geschätzter Aufwand
1-3 Stunden
Anfängerfreundlichkeit
55/100
Issue-Typ
Feature
Klarheit
Klar beschrieben
Aktivitätsstatus
Veraltet
Tech-Stack
typescript
Bereich
api

Rechercherichtung

Start by locating the ScheduleItem interface in the TypeScript definitions and compare its fields with the four properties shown in the issue’s Graph Explorer response: isMeeting, isRecurring, isException, and isReminderSet. Add the missing typings and verify that the generated or maintained definitions accept those properties. Done when all four response fields are represented in ScheduleItem.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

ToTriage

When requesting schedule items via
https://graph.microsoft.com/v1.0/me/calendar/getSchedule

The response is missing some attributes in the ScheduleItem

Existing typing:

export interface ScheduleItem {
    // The date, time, and time zone that the corresponding event ends.
    end?: NullableOption<DateTimeTimeZone>;
    // The sensitivity of the corresponding event. True if the event is marked private, false otherwise. Optional.
    isPrivate?: NullableOption<boolean>;
    // The location where the corresponding event is held or attended from. Optional.
    location?: NullableOption<string>;
    // The date, time, and time zone that the corresponding event starts.
    start?: NullableOption<DateTimeTimeZone>;
    /**
     * The availability status of the user or resource during the corresponding event. The possible values are: free,
     * tentative, busy, oof, workingElsewhere, unknown.
     */
    status?: NullableOption<FreeBusyStatus>;
    // The corresponding event's subject line. Optional.
    subject?: NullableOption<string>;
}

Return type from graph explorer

                {
                    "isPrivate": false,
                    "status": "busy",
                    "subject": "Microsoft Graph community call",
                    "location": "Microsoft Teams meeting",
                    "isMeeting": false,             <-- new
                    "isRecurring": true,            <-- new
                    "isException": false,            <-- new
                    "isReminderSet": true,            <-- new
                    "start": {
                        "dateTime": "2023-07-04T15:00:00.0000000",
                        "timeZone": "UTC"
                    },
                    "end": {
                        "dateTime": "2023-07-04T16:00:00.0000000",
                        "timeZone": "UTC"
                    }
                }

These values are missing in the typing

  • "isMeeting": false
  • "isRecurring": true
  • "isException": false
  • "isReminderSet": true

The official docs also do net mention them:
https://learn.microsoft.com/en-us/graph/api/resources/scheduleitem?view=graph-rest-1.0

I'll open a ticket there as well.

Best

Vorherrschende Sprache
PowerShell
Sterne
129
Forks
35
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus microsoftgraph/msgraph-typescript-typings

Alle Issues in microsoftgraph/msgraph-typescript-typings

Ähnliche Issues

Weitere Issues zu Backend & API Design

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.