Serialisation/deserialisation no longer works

Offen
#1,556 2 Kommentare 1 Reaktion 0 zugewiesene Personen Auf GitHub ansehen

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
5/5
Geschätzter Aufwand
Über eine Woche
Anfängerfreundlichkeit
30/100
Issue-Typ
Bug
Klarheit
Größtenteils klar
Aktivitätsstatus
Veraltet
Tech-Stack
php
Bereich
api

Rechercherichtung

Beginnen Sie mit den Message- und ItemBody-Modellen und dem im Bericht beschriebenen Abonnement des backing store, und reproduzieren Sie anschließend den Fehler mit PHP serialize() und unserialize(). Überprüfen Sie readme.md und upgrade.md auf Aussagen zur Serialisierung. Als erledigt gilt die Aufgabe, wenn native Serialisierung und Deserialisierung für SDK-Modelle mit verschachtelten Objekten funktionieren oder die Dokumentation die unterstützte Alternative eindeutig angibt.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

type:enhancement
Describe the bug

Native serialisation and deserialisation of models no longer works in v2.

In the msgraph-sdk-php-core readme.md file it states:

We provide Microsoft Graph models for easy serialization and deserialization.

If you would like to leverage the models we provide, please take a look at the [Microsoft Graph PHP SDK](https://packagist.org/packages/microsoft/microsoft-graph) and for beta models - the [Microsoft Graph Beta PHP SDK](https://packagist.org/packages/microsoft/microsoft-graph-beta).

Sadly this is no longer the case. As soon as any nested object is added to a model, serialisation fails as the embedded closures cannot be serialised.

Admittedly this text is obviously written for V1 as it references Graph Beta, but I don't think it has been intentional to remove the ability to natively serialise models. If that is the case, I think that is a bad move. I don't think there in anything in the upgrade.md file that suggests you can no longer natively serialize and, importantly, deserialize models. No examples exist describing how to do this using the SDK.

Take for example the Message model, in it's basic form you can serialise it, however as soon as you add an ItemBody element you can't because the backing store now contains a subscriber for changes to the ItemBody, which is implemented as a closure. This prevents the Message model from being serialised using native PHP serialize/unserialize methods.

My usage case is that I need to offload the sending of messages to a background task. The messages are created when forms are submitted etc. and saved to a scheduler list which picks them up via a command line background task, and then performs the actual sending of the Message object.

There are already issues that hint towards this problem but not to the actual cause of the error:
https://github.com/microsoftgraph/msgraph-sdk-php/issues/1471
https://github.com/microsoftgraph/msgraph-sdk-php/issues/1470
https://github.com/microsoftgraph/msgraph-sdk-php/issues/1452

Expected behavior

Native serialize and unserialize methods should work with all SDK models.

How to reproduce

This simple code will crash when attempting to serialise the Message object:

    $message = new Message();
    $message->setSubject('Test');
    $body = new ItemBody();
    $body->setContentType(new BodyType(BodyType::HTML));
    $body->setContent('<p>Test</p>');
    $message->setBody($body); // Causes a subscription to be set on ItemBody
    $test = serialize($message); // This would be stored for the background task.
SDK Version

v2.12.0

Latest version known to work for scenario above?

v1

Known Workarounds

None.

Debug output
Click to expand log object(Exception)#705 (7) { ["message":protected]=> string(41) "Serialization of 'Closure' is not allowed" ["string":"Exception":private]=> string(0) "" ["code":protected]=> int(0) ["file":protected]=> string(64) "redacted.php" ["line":protected]=> int(220) ["trace":"Exception":private]=> array(5) { ... } ```
Configuration

No response

Other information

No response

Vorherrschende Sprache
PHP
Sterne
669
Forks
149
Ø Merge
1 T. 4 Std.
Gemergte PRs (30 T.)
5

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus microsoftgraph/msgraph-sdk-php

Alle Issues in microsoftgraph/msgraph-sdk-php

Ähnliche Issues

Weitere Issues zu PHP

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.