[Regression]: evaluate() with larger results ~40% slower since 1.65
Maintainer antworten meist innerhalb von 1 Tag
Dieses Issue hat noch niemand übernommen.
Bewertung
- Schwierigkeit
- 3/5
- Geschätzter Aufwand
- 1-2 Tage
- Anfängerfreundlichkeit
- 62/100
- Issue-Typ
- Bug
- Klarheit
- Klar beschrieben
- Aktivitätsstatus
- Aktiv
- Tech-Stack
- python
- Bereich
- performance
Rechercherichtung
Start in protocol/validator_primitives.py, reading t_object and the t_optional helper, and trace where SerializedValue's schema keys are iterated. Before editing, run the issue's page.evaluate benchmark script to record a baseline, then re-run it after skipping the optional-key validators when a key is absent. Also run the protocol validator tests in tests/ (the suite that round-trips validated messages) to confirm malformed messages are still rejected. Done means the benchmark is back near 1.30s with unchanged validation behaviour, including for events and initializers.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
Last Good Version
1.64.0
First Bad Version
1.65.0
Steps to reproduce
evaluate() with a medium-sized result got about 40% slower:
import time
from playwright.sync_api import sync_playwright
JS = "Array.from({length: 200}, (_, i) => ({id: i, name: 'item ' + i, price: i * 1.5, url: 'https://example.com/' + i, tags: ['a', 'b']}))"
with sync_playwright() as p:
page = p.chromium.launch().new_page()
page.evaluate(JS)
best = 1e9
for _ in range(3):
start = time.perf_counter()
for _ in range(300):
page.evaluate(JS)
best = min(best, time.perf_counter() - start)
print(f"{best:.2f}s")
Expected behavior
1.64.0: 1.30s
Actual behavior
1.65.2: 1.84s
Additional context
cProfile points at the protocol validator: the t_object validator in protocol/validator_primitives.py is about 60% of the profiled time. For every object node it calls the validator of every key in the schema, and SerializedValue has ~15 optional keys, so most calls are t_optional(None) for keys that aren't there. It also calls context.is_under_test() once per node.
Skipping the call when the key is absent and the validator is a t_optional (the result is None in that case anyway) brings the script above to 1.47s in my test, same output. Validated messages also include every event and initializer, so it's not only evaluate.
Environment
- Operating System: macOS 27.2
- CPU: arm64
- Browser: Chromium
- Python Version: 3.14
- Other info:
- Vorherrschende Sprache
- Python
- Sterne
- 15.1k
- Forks
- 1.3k
- Ø Merge
- 6 Std. 16 Min.
- Gemergte PRs (30 T.)
- 53
Entwicklungsumgebung
- Kein Dockerfile und keine Docker-Compose-Datei
- Keine Pull-Request-Vorlage
- Beitragsleitfaden lesen
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus microsoft/playwright-python
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 74/100
microsoft/playwright-python#3361 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 65/100
microsoft/playwright-python#3360 ·
Maintainer antworten meist innerhalb von 1 Tag
Alle Issues in microsoft/playwright-python
Ähnliche Issues
-
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 88/100
snap-stanford/Biomni#380 ·
-
documentation priority: low size: S status: needs triage
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 74/100
cubrid-lab/sqlalchemy-cubrid#1397 ·
Maintainer antworten meist innerhalb von 1 Tag
-
documentation priority: low size: S status: needs triage
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 72/100
cubrid-lab/pycubrid#1307 ·
Maintainer antworten meist innerhalb von 1 Tag
-
[Bug]: Installer hides SSL certificate errors as bare URLError, and the suggested fix can't workOffenbug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 80/100
ShaftHQ/chaosengine-harness#143 ·
Maintainer antworten meist innerhalb von 1 Tag
-
bug high-severity
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 72/100
aws/bedrock-agentcore-sdk-python#752 ·
Maintainer antworten meist innerhalb von 1 Tag