FEAT: Built-in configurable connection and transient-fault retry logic
Maintainer antworten meist innerhalb von 2 Tagen
Bewertung
Dieses Issue wurde noch nicht bewertet.
Beschreibung
Summary
Add first-class, configurable retry logic to mssql-python so applications get transient-fault resiliency without hand-rolling their own retry loops. Today the only retry surface is the ODBC-level ConnectRetryCount/ConnectRetryInterval keywords, which only silently reconnect a dropped idle connection. They do not retry a connect() that fails transiently, nor a query that fails with a recoverable error (deadlock victim, lock/query timeout, or Azure SQL throttling such as 40197/40501/49918). Every app has to reimplement this, and most get the backoff, jitter, and "which errors are retriable" classification subtly wrong.
Motivation
- Parity with the .NET Microsoft.Data.SqlClient configurable retry providers (
SqlRetryLogicBaseProvider,SqlConnection.RetryLogicProvider/SqlCommand.RetryLogicProvider) and the Azure SDK retry-policy conventions. - Azure SQL Database and SQL Managed Instance routinely surface transient errors during failover, scaling, and throttling; robust handling is effectively required for production.
- Reduces copy-pasted, error-prone retry loops and centralizes the transient-error taxonomy in the driver where it can be maintained authoritatively.
Proposed API (for discussion)
A retry policy object, attachable at the connection level and overridable per cursor/execute:
from mssql_python import RetryPolicy, connect
policy = RetryPolicy(
max_attempts=3, # total tries, not extra retries
backoff="exponential", # "exponential" | "fixed" | "none"
base_delay=1.0, # seconds
max_delay=30.0, # cap per wait
jitter=True, # full jitter to avoid thundering herd
# Retriable classification, defaulted by the driver but overridable:
# connect-scope errors -> fresh connection; query-scope -> same connection
)
conn = connect(conn_str, retry_policy=policy) # applies to connect() + queries
cursor = conn.cursor(retry_policy=policy) # optional override
cursor.execute(sql, *params, retry_policy=policy) # optional per-call override
Key behaviors:
- Two scopes, because recovery differs: connection-establishment/connection-loss errors need a fresh connection; connection-surviving errors (deadlock, query timeout, throttling) retry on the same connection.
- Driver-maintained default retriable set (transient SQLSTATEs / native error numbers), overridable by the caller.
- Idempotency guardrail: by default only retry statements the caller marks safe, or document clearly that writes must be wrapped in an explicit transaction. Never silently replay a non-idempotent write.
- Observability: emit standard
loggingrecords on each retry (attempt count, error, delay) and on final give-up. - No behavior change by default (opt-in), so existing code is unaffected.
Alternatives considered
- ODBC
ConnectRetryCount/ConnectRetryInterval— only covers idle-connection reconnect, notconnect()or query retries. - Application-level helper loops — what everyone does now; duplicative and easy to get wrong (backoff, jitter, error classification, connect-vs-query scope).
Additional context
Docs currently ship a sample connect_with_retry / execute_with_retry pattern that demonstrates exactly this behavior and would map cleanly onto a built-in RetryPolicy.
- Vorherrschende Sprache
- Python
- Sterne
- 478
- Forks
- 62
- Ø Merge
- 3 T. 1 Std.
- Gemergte PRs (30 T.)
- 26
Entwicklungsumgebung
Startet den Dev-Container des Projekts im Browser, mit Ihrem eigenen GitHub-Konto.
- Kein Dockerfile und keine Docker-Compose-Datei
- Hat eine Pull-Request-Vorlage
- Beitragsleitfaden lesen
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus microsoft/mssql-python
-
area: bulk-copy triage needed
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 70/100
microsoft/mssql-python#843 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 2 Tagen
-
triage needed
Schwierigkeit 5/5 Über eine Woche Anfängerfreundlichkeit 38/100
microsoft/mssql-python#850 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 2 Tagen
-
triage needed
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 22/100
microsoft/mssql-python#849 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 2 Tagen
-
triage needed
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 20/100
microsoft/mssql-python#848 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 2 Tagen
-
triage needed
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 35/100
microsoft/mssql-python#846 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 2 Tagen
Alle Issues in microsoft/mssql-python
Ähnliche Issues
-
`lvm_compact` has no self-hosted twin, and `docs/158` §5 says every language-face component mustOffenbug sev-3 vm
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 65/100
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 82/100
sierra-research/tau2-bench#635 ·
Maintainer antworten meist innerhalb von 1 Tag
-
The add-ssm-model skill requires a Cython simulator; the contributing guide allows Python onesEvtl. vergeben @fmuia hat das heute übernommen. Offendocumentation skill
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 83/100
lnccbrown/ssm-simulators#406 ·
Maintainer antworten meist innerhalb von 4 Tagen
-
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 95/100
btclib-org/btclib-ecc#309 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 74/100
autowarefoundation/autoware_carla_scenario#281 ·
Maintainer antworten meist innerhalb von 1 Tag