Simplify the generate ai-briefing plugin code (2 of 3)

Offen
  • Stimmt etwas nicht?
#14,388 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
55/100
Issue-Typ
Refactoring
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
javascript
Bereich
developer-experience

Rechercherichtung

Read the ten listed files under plugins/ai-briefing/skills/generate/output/build/ and review them against the four /simplify checks: helper reuse, simpler code, efficiency, and abstraction level. Preserve their outputs, exit codes, written files, printed messages, flags, and exported names; keep changes within the stated file and line limits. Add the required ai-briefing changelog fragment, then verify the relevant checks and CI.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

status: ready

Agent Brief

Type: Task
Summary: Simplify these 10 files without changing their behavior (part of the /simplify epic).

Current behavior:
The files below work as they do on main. Their code changes; what they do does not.

Desired behavior:
Review the files through /simplify's four checks (reuse of existing helpers, simplification, efficiency, right level of abstraction), using subagents if useful, and apply the fixes. The files end up shorter and clearer, and whatever runs them gets the same results.

Files:

  • plugins/ai-briefing/skills/generate/output/build/emit-slides-data.js
  • plugins/ai-briefing/skills/generate/output/build/lib/brand-overlay.js
  • plugins/ai-briefing/skills/generate/output/build/lib/emit-slides.js
  • plugins/ai-briefing/skills/generate/output/build/lib/parse-briefing.js
  • plugins/ai-briefing/skills/generate/output/build/lib/paths.js
  • plugins/ai-briefing/skills/generate/output/build/lib/provider-logos.js
  • plugins/ai-briefing/skills/generate/output/build/lib/schema.js
  • plugins/ai-briefing/skills/generate/output/build/lib/url-display.js
  • plugins/ai-briefing/skills/generate/output/build/lib/url-policy.js
  • plugins/ai-briefing/skills/generate/output/build/run.js

Key interfaces:

  • Outputs, exit codes, written files and printed messages of these files: unchanged.
  • Command-line flags, exported names and anything another file calls: unchanged.

Acceptance criteria:

  • Behavior is unchanged: same outputs, exit codes, written files, printed text, command-line flags and exported names; no listed file renamed, moved or deleted.
  • The diff edits only the listed files, the lines of a test that assert on them when the change breaks that assertion, and changelog fragments.
  • The pull request stays within 400 changed lines and 15 hand-edited files (generated shared copies and changelog fragments not counted); anything beyond goes under ## Follow-ups in the pull request body.
  • ci-status is green.
  • Each touched plugin (ai-briefing) has a fragment from scripts/new-changelog-fragment.sh <plugin> patch whose body is ### Changed and the line "Internal simplification, no behavior change."

Out of scope:

  • Moving code between files or deduping across them: the sub-epic's restructuring pass does that after these chunks merge.
  • Tests beyond the asserted lines a change breaks, eval cases, fixtures, and skill and agent text.
  • Files listed in other chunks.
  • These eval and fixture files, which read the listed files' names, flags or printed text; the behavior rule keeps them accurate:
    • plugins/ai-briefing/evals/gen-two-weeks-markdown/case.yaml
Vorherrschende Sprache
Shell
Sterne
22
Forks
2
Ø Merge
53 Min.
Gemergte PRs (30 T.)
961

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus melodic-software/claude-code-plugins

Alle Issues in melodic-software/claude-code-plugins

Ähnliche Issues

Weitere Issues zu Shell/Bash

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.