Hacktoberfest 2026: die Issues, die Maintainer für den Oktober markiert haben – offen und einsteigerfreundlich. Hacktoberfest-Issues durchsuchen

Nested classes wipe the outer class's field refinements

Offen
  • Stimmt etwas nicht?
#317 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 2 Tagen

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
55/100
Issue-Typ
Bug
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
java
Bereich
compilers

Rechercherichtung

Start in RefinementTypeChecker.visitCtClass and MethodsFirstChecker.visitCtClass, focusing on how context.reinitializeContext() changes ctxVars while Spoon visits nested classes. Use the OuterWiped reproducer to verify that the outer field refinement remains available after Inner, while writes such as x = -1 are still rejected. Done means the reproducer passes verification without losing the existing write check.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

bug

Description

Entering a nested class resets the variable context, which wipes the outer class's fields. Any method of the outer class declared after a nested class loses the refinements of the outer class's own fields.

Minimal reproducer

import liquidjava.specification.Refinement;

public class OuterWiped {
    @Refinement("_ > 0") int x = 1;

    static class Inner { int y; }

    @Refinement("_ > 0")
    public int get() { return x; }
}

Expected

Correct! Passed Verification.

Actual

Refinement Error: true is not a subtype of #ret¹ > 0
6 |     public int get() { return x; }
  |                        ^^^^^^^^^
 --> Not enough information to prove the expected refinement. Add a refinement or condition to constrain it.

Removing Inner (or moving it below get) makes it pass. Writes such as x = -1 are still rejected correctly, because the expected refinement is read from the field's annotation.

Cause

RefinementTypeChecker.visitCtClass (and MethodsFirstChecker.visitCtClass) call context.reinitializeContext(), which clears ctxVars. Spoon visits nested classes as children of the outer class, so visiting Inner clears this#x. The opposite also happens: the nested class's fields stay in the context after it returns. That leak is why declaring a nested class before its use works today (see #308).

Possible fix

When a class is entered, register all of its fields (and those of its nested types) before visiting any methods, and keep nested classes from clearing the enclosing class's context. This would probably also fix the read case above.

Reproduced on main at fbfb4e23 (liquidjava-verifier 0.0.35).

Vorherrschende Sprache
Java
Sterne
67
Forks
36
Ø Merge
3 T. 16 Std.
Gemergte PRs (30 T.)
9

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus liquid-java/liquidjava

Alle Issues in liquid-java/liquidjava

Ähnliche Issues

Weitere Issues zu Java

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.