Account and settings views crash on malformed request bodies

Offen
#6,388 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
56/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
python

Rechercherichtung

Start with the listed view entry points in contentcuration/views/users.py, settings.py, admin.py, and base.py, then read the serializer strategy in issue #6387 and the related forms in contentcuration/forms.py. Add regression coverage for each listed malformed input and confirm each returns 400 naming the invalid or missing field. Verify that well formed requests keep their existing status codes and response bodies.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

DEV: backend

❌ This issue is not open for contribution. Visit Contributing guidelines to learn about the contributing process and how to find suitable issues.

Overview

The account and settings views parse the request body with json.loads(request.body) and read fields by key without checking the body's shape. A body that isn't valid JSON, isn't a JSON object, is missing a field, or has a field of the wrong type raises an exception, and the request returns 500. Most of these views are reachable without logging in: login, registration, password reset and request activation link.

Complexity: Medium
Target branch: hotfixes

Context

All sites below fail with the inputs shown, and each input was reproduced:

The Change
  • Each view in Context should validate its request body with a DRF serializer, following the strategy in #6387, and return 400 for any malformed body.
  • Well-formed requests should keep their current status codes and response bodies, because the frontend depends on them.
Acceptance Criteria
General
  • Every input listed in Context returns 400 instead of 500.
  • Each 400 response names the invalid or missing field.
  • Well-formed requests to each view return the same status code and body as before.
Testing
  • Each view has a regression test that sends a malformed body and asserts 400.

AI usage

I scoped the audit and chose the validation strategy in #6387. Claude Code found and reproduced these failures and drafted this issue.

Vorherrschende Sprache
Python
Sterne
212
Forks
321
Ø Merge
1 T. 7 Std.
Gemergte PRs (30 T.)
14

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus learningequality/studio

Alle Issues in learningequality/studio

Ähnliche Issues

Weitere Issues zu Python

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.