storage: createReadStream() never errors when a download stalls mid-body
Maintainer antworten meist innerhalb von 1 Tag
Dieses Issue hat noch niemand übernommen.
Bewertung
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Anfängerfreundlichkeit
- 30/100
- Issue-Typ
- Feature
- Klarheit
- Größtenteils klar
- Aktivitätsstatus
- Aktiv
- Tech-Stack
- javascript, node.js, typescript
- Bereich
- networking
Rechercherichtung
Start from File#createReadStream in the storage library and trace how it builds the underlying request through teeny-request/node-fetch, since the issue states the documented timeout no longer covers the response body after headers arrive (storage >= 8.0.1). The reproduction script (a local HTTP server that sends headers and a partial body) is the first thing to run to confirm the current hang. Done means a stalled stream emits an error after an idle interval and a test covers that path.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
Library name
@google-cloud/storage
What would you like to see in the library?
An idle timeout for File#createReadStream(): if no body bytes arrive for a set time, the stream emits an error.
Why
A download that stops mid-body never emits an error or end, so a pipeline that reads from the stream waits forever. In production we see occasional downloads of multi-gigabyte objects stop partway through. Each one then hung for days until we stopped the process by hand.
This worked in early versions. In 2017, a stalled createReadStream() raised ESOCKETTIMEOUT (#2317), because the library used request, whose timeout set a socket idle timeout. That protection was lost later:
- With teeny-request 9.x / node-fetch 2 (storage ≤ 8.0.0), the request
timeoutstopped when the response headers arrived. node-fetch 2 applied its body timeout only to buffered reads (.text(),.json()), not to a piped stream. - With teeny-request ≥ 10 (storage ≥ 8.0.1), the documented
timeouthas no effect at all. See #9514.
googleapis/nodejs-storage#24 reports the same hang. Its last comment (storage 6.12, Node.js 20) also sees streams that hang forever.
Reproduction
storage 8.1.0, Node.js 22.22.1:
const http = require('node:http')
const { Storage } = require('@google-cloud/storage')
// The server sends the response headers and part of the body, then stops sending.
const server = http.createServer((req, res) => {
res.writeHead(200, { 'content-type': 'application/octet-stream' })
res.write('first part of the file\n')
})
server.listen(0, () => {
const storage = new Storage({
apiEndpoint: `http://127.0.0.1:${server.address().port}`,
projectId: 'repro',
useAuthWithCustomEndpoint: false,
})
let bytes = 0
storage.bucket('bucket').file('file.jsonl').createReadStream({ validation: false })
.on('data', (chunk) => { bytes += chunk.length })
.on('error', (err) => { console.log('error:', err.message); process.exit(0) })
.on('end', () => { console.log('end'); process.exit(0) })
setTimeout(() => {
console.log(`after 90 s: ${bytes} bytes received, no error, no end`)
process.exit(1)
}, 90000)
})
Output: after 90 s: 23 bytes received, no error, no end
Alternatives considered
We now wrap the stream in our own watchdog. It aborts the pipeline when no data moves for 10 minutes. Every user who streams large objects has to build the same thing. Node's built-in fetch (undici) has bodyTimeout for this case, with a default of 5 minutes.
- Vorherrschende Sprache
- TypeScript
- Sterne
- 3.2k
- Forks
- 732
- Ø Merge
- 2 T. 11 Std.
- Gemergte PRs (30 T.)
- 99
Entwicklungsumgebung
- Kein Dockerfile und keine Docker-Compose-Datei
- Hat eine Pull-Request-Vorlage
- Beitragsleitfaden lesen
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus googleapis/google-cloud-node
-
Broken deprecation chainOffen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 66/100
googleapis/google-cloud-node#9854 ·
Maintainer antworten meist innerhalb von 1 Tag
-
pubsub: "Operation attempted on ended Span" when a modack is flushed after the message was ackedOffenapi: pubsub
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 82/100
googleapis/google-cloud-node#9853 ·
Maintainer antworten meist innerhalb von 1 Tag
-
storage: V4 getSignedUrl sorts canonical headers with localeCompare, so they disagree with X-Goog-SignedHeadersEvtl. vergeben @itsrayeedscodespace hat das vor 9 Tagen übernommen. Offenapi: storage
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 82/100
googleapis/google-cloud-node#9840 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 1 Tag
-
firestore: getPartitions() emits gax AutopaginateTrueWarning in every processEvtl. vergeben @TheRealDanii hat das vor 13 Tagen übernommen. Offenapi: firestore
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 76/100
googleapis/google-cloud-node#9736 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 82/100
googleapis/google-cloud-node#9723 ·
Maintainer antworten meist innerhalb von 1 Tag
Alle Issues in googleapis/google-cloud-node
Ähnliche Issues
-
bot:ai-assisted component:platform-js status:untriaged
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 74/100
midnightntwrk/platform-js#38 ·
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 68/100
ranxianglei/billion-context#7068 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
mybigday/whisper.rn#348 ·
-
enhancement severity:low
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 82/100
Battle-Cattle/BCUK-Bot-4#1075 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 67/100
ilan-pinto/roaring-lions#1552 ·
Maintainer antworten meist innerhalb von 1 Tag